Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-210: replanning updates for actionTree #211

Merged
merged 10 commits into from
Nov 8, 2019
Merged

Conversation

zmknox
Copy link
Contributor

@zmknox zmknox commented Oct 31, 2019

Resolves issue: #210

Changes proposed in this pull request:

  • Update offlineReplanning to support actionTree algorithm
    • This uses some randomness to help stop the algorithm from going down the same path all the time. This randomness can be seeded from the config with replanningSeed.
    • If you plan to use replanning with your existing actionTree models, you will likely need to update your models to better reflect how your website works, as opposed to expecting only one path to be taken. Future developments will allow this to be done easier.
  • Updated reduce-to-minimum-set-of-plans to compare hashes of plans. In the past, it was comparing sets in a way which would never detect duplicates. In the future, it might be nice to compare sets to detect true supersets of plans.

@GannettDigital/simulato-core-contributors

Copy link
Contributor

@scottgunther scottgunther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A welcome addition! Here is some feedback.

lib/planner/reduce-to-minimum-set-of-plans.js Outdated Show resolved Hide resolved
lib/planner/search-algorithms/offline-replanning.js Outdated Show resolved Hide resolved
lib/planner/search-algorithms/offline-replanning.js Outdated Show resolved Hide resolved
lib/util/expected-state.js Outdated Show resolved Hide resolved
lib/planner/write-plans-to-disk.js Show resolved Hide resolved
@zmknox zmknox requested a review from scottgunther November 8, 2019 15:23
Copy link
Contributor

@scottgunther scottgunther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

Please add the documentation for the new option in the documentation. Thanks.

lib/planner/search-algorithms/offline-replanning.js Outdated Show resolved Hide resolved
@zmknox zmknox requested a review from scottgunther November 8, 2019 18:59
@scottgunther scottgunther merged commit 0ecfbaa into master Nov 8, 2019
@scottgunther scottgunther deleted the issue-210 branch November 8, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants