Update to Python 3 #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any hope of this being merged? I'm looking at adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since January 2020, Python 2 is no longer supported, and no longer gets updates. Many other packages no longer support it.
I just ran the
2to3tool on the project and went through the changes. I haven't tested everything though.The primary change was just going from
xrangetorange, which does the same thing in Python 3. Mostprintstatements were already using parentheses for some reason so those were fine.2to3assumes you wanted a list fromdict.keys()andmapso it wraps those calls. That might not be necessary (I didn't review all the uses) but it should maintain functionality at least.