[GSK-2248] TestResult to dict #9
Conversation
GSK-2248 Generate JSON output from the tests
This should be the last step of the short-term milestone. We should get feedback from Alex on this to finalise the format. |
loreal_poc/dataloaders/base.py
Outdated
| self._wrapped_dataloader = dataloader | ||
| self.name = name |
There was a problem hiding this comment.
Not needed, any call to .name would be redirected to self._wrapped_dataloader.name, using __getattr__
Or you could add a func with @property.getter, to add some description like :
@property.getter
def name(self):
return f"Wrapper({self._wrapped_dataloader.name}")
loreal_poc/dataloaders/wrappers.py
Outdated
| @@ -16,7 +16,8 @@ def __init__( | |||
| crop_img: bool = True, | |||
| crop_marks: bool = True, | |||
| ) -> None: | |||
| super().__init__(dataloader) | |||
| name = f"Cropped on {part.name}" | |||
There was a problem hiding this comment.
Kind of same as for the base class, could be a method
@property.getter
def name(self):
return f"{self._wrapped_dataloader.name} cropped on {self._part}")
loreal_poc/dataloaders/wrappers.py
Outdated
| @@ -46,7 +47,7 @@ def __getitem__(self, idx: int) -> Tuple[np.ndarray, Optional[np.ndarray], Optio | |||
|
|
|||
| class CachedDataLoader(DataLoaderWrapper): | |||
| def __init__(self, dataloader: DataIteratorBase, cache_size: int = 20) -> None: | |||
| super().__init__(dataloader) | |||
| super().__init__(dataloader, name="Cached") | |||
| str(round(self.threshold, 2)), | ||
| f"Prediction fail rate: {FR}" if FR != 0 else "", | ||
| str(round(self.prediction_time, 2)), | ||
| ) | ||
|
|
||
| def to_dict(self): | ||
| return { |
There was a problem hiding this comment.
Could use dataclasses.asdict instead.
There was a problem hiding this comment.
For now I don't need all the attributes of TestResult to be included. But yeah, probably the remaining ones could be eliminated in the future if we don't need them, and to_dict can be therefore also eliminated in favour of asdict. Thanks!
No description provided.