Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use image/jpeg as the target format #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mweibel
Copy link

@mweibel mweibel commented Aug 28, 2020

when using the Chrome's native ImageCapture it outputs a JPEG. Default HTMLCanvasElement.toBlob() outputs a png unless otherwise specified.
This change aligns those two implementations.

when using the Chrome's native ImageCapture it outputs a JPEG. Default [`HTMLCanvasElement.toBlob()`](https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/toBlob) outputs a `png` unless otherwise specified.
This change aligns those two implementations.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mweibel
Copy link
Author

mweibel commented Aug 28, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants