Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update min version to 1.21 #4392

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Sep 18, 2024

Noticed this was still needed in #4383. Note we should also switch latest to 1.23, but I did not in this PR because the image has not been built yet.

Noticed this was still needed in GoogleCloudPlatform#4383. Note we should also switch
latest to 1.23, but I did not in this PR because the image has not
been built yet.
@codyoss codyoss requested a review from a team as a code owner September 18, 2024 14:16
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 18, 2024
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Sep 18, 2024
@telpirion telpirion enabled auto-merge (squash) September 18, 2024 16:42
@telpirion telpirion self-assigned this Sep 18, 2024
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 19, 2024
@muncus
Copy link
Collaborator

muncus commented Oct 24, 2024

I've reviewed the failed tests, and none appear related to the version update (capacity or server-side quota issues)

@muncus muncus requested a review from a team as a code owner October 24, 2024 17:57
@muncus muncus disabled auto-merge October 24, 2024 21:05
@muncus muncus merged commit c3c2dae into GoogleCloudPlatform:main Oct 24, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants