Create a script to programatically create OAuth secret for IAP #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add shell in asm makefile. Fixes GoogleCloudPlatform#389. * Upgrade MySQL to 8.0 * Upgrade kfp to v2.0.0-alpha.5 * Update CHANGELOG * Upgrade upstream to v1.6.1 * Add namespace spcification * Update changelog and add a comment about CloudSQL * Increase delay before deleting iap helper workloads to 90 sec * Upgrade KFP to 2.0.0-alpha.6 * Update changelog * Remove mysql version from comments * Fix asmcli installation path * Fix asmcli installation path * Fix upstream folder in ASM * Update upstream folder for asm
|
/assign @gkcalat @zijianjoy |
zijianjoy
reviewed
Dec 5, 2022
| # not provided. | ||
| # | ||
| # To find more information about the commands, please see | ||
| # https://cloud.google.com/iap/docs/programmatic-oauth-clients. |
There was a problem hiding this comment.
How do we provide redirect URI via command line approach? https://www.kubeflow.org/docs/distributions/gke/deploy/oauth-setup/
There was a problem hiding this comment.
Seems like redirect URIs are not supported in the commandline. Should we provide an option that skips this step if the user needs redirects?
There was a problem hiding this comment.
I think redirects is required for Kubeflow deployment to work, please correct me if I am wrong.
cc @gkcalat
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the work in #397.
This change integrates the
setup_iap_ingress.shscript into the Makefile so the OAuth client and secret are automatically created if they do not exist. If theCLIENT_IDandCLIENT_SECRETenvironment variables are created then the script will simply use them to create the IAP secret.