Adding prow job config for gcsfuse pytorch dino model for test #1950
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sethiay The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @sethiay. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/retest |
prow/prowjobs/GoogleCloudPlatform/gcsfuse/gcsfuse-pytorch-dino-periodic.yaml
Outdated
Show resolved
Hide resolved
|
/retest |
|
@sethiay: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/assign |
Prow jobs in this repository must contain TestGrid annotations or be explicitly opted-out. Try removing the commit that deletes the TestGrid annotations. |
| @@ -0,0 +1,33 @@ | |||
| periodics: | |||
| - name: gcsfuse-pytorch-dino-periodic | |||
| cluster: gcsfuse-prow-test | |||
There was a problem hiding this comment.
{"component":"checkconfig","file":"k8s.io/test-infra/prow/cmd/checkconfig/main.go:91","func":"main.reportWarning","level":"warning","msg":"invalid periodic job: job configuration for "gcsfuse-pytorch-dino-periodic" specifies unknown 'cluster' value "gcsfuse-prow-test"","severity":"warning","time":"2023-05-18T19:00:49Z"}
Is this a new cluster? Prow doesn't seem to recognize it. Can you point to where it was configured?
There was a problem hiding this comment.
Yes, this is a new cluster. I just ran https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/prow/oss/create-build-cluster.sh. Is there any other configurations that I need to do ? If yes, please point to it.
Prow jobs in this repository must contain TestGrid annotations or be explicitly opted-out. Try removing the commit that deletes the TestGrid annotations.
I removed the TestGrid annotations because that was giving me error - "No dashboard found". Do I have to first create the TestGrid dashboard ? If yes, is it true that I just need to add an entry here; https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/testgrid/config.yaml ?
There was a problem hiding this comment.
As far as TestGrid dashboards go, that's correct; add your new dashboard there and then you can use it in an annotation.
As for what steps you need to take after running that script for Prow to recognize a new build cluster; I'll look into that
|
Ignore my last comment (deleted it). I missread the PR. Still looking into this |
| @@ -0,0 +1,33 @@ | |||
| periodics: | |||
| - name: gcsfuse-pytorch-dino-periodic | |||
| cluster: gcsfuse-prow-test | |||
There was a problem hiding this comment.
I don't think this is the correct name for the cluster you created. Typically the script creates a cluster with the name build-{TEAM} so I think yours is build-gcsfuse
There was a problem hiding this comment.
I changed the name in the script to gcsfuse-prow-test and can confirm cluster with this name is present in my project as well.
There was a problem hiding this comment.
I think maybe you did not edit the script correctly.
It looks like the cluster is configured as build-gcsfuse https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/prow/oss/gencred-config/gencred-config.yaml
and build-gcsfuse is in a lot of the config https://grep.app/search?q=build-gcsfuse&filter[repo][0]=GoogleCloudPlatform/oss-test-infra
I am not seeing any config for gcsfuse-prow-test
There was a problem hiding this comment.
okay, I will creating another cluster again.
This commit adds: