Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing distro files from Flatpak and Arch Linux #130

Merged
merged 24 commits into from
Jan 20, 2025
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
f6e2c1b
old screenshots from fedora-appstream
cengique May 31, 2024
ae96336
2 old screenshots from grangerhub
cengique May 31, 2024
c367954
grangerhub logo and screenshots downloaded from forum
cengique Jun 1, 2024
d812950
appstream and desktop files from flathub and arch linux package, resp…
cengique Jun 2, 2024
0882a03
replaced with correct files from asciiwolf PR to flathub
cengique Jun 2, 2024
6ee082b
Added screenshots in appdata, added 2 videos, imported AsciiWolf's dr…
cengique Jun 3, 2024
a1e36fe
added Linux install target for superuser; removed some .PHONY targets
cengique Jun 11, 2024
cd6c2d4
removed redundant old screenshot
cengique Jun 11, 2024
6946d98
path corrections
cengique Jun 14, 2024
7899d86
adjusting Makefile, install files, and directories. Removing lowres s…
cengique Jun 16, 2024
769d1f8
Remove paragraph from misc/io.github.grangerhub.Tremulous.appdata.xml
cengique Aug 26, 2024
92d393c
changing name back to Tremulous and updating other names for consistency
cengique Aug 26, 2024
ce074a6
Fixes for clarity and consistency requested by AsciiWolf
cengique Oct 7, 2024
3943f6f
Update misc/io.github.grangerhub.Tremulous.desktop
cengique Jan 19, 2025
61934eb
Minor fixes suggested by AsciiWolf
cengique Jan 19, 2025
ea31b0b
Remove URL from appdata
cengique Jan 20, 2025
20b3543
testing quick fix to curl build error
cengique Jan 20, 2025
6ca89f6
USE_LOCAL_HEADERS in Github Actions linux build
cengique Jan 20, 2025
f345855
USE_CURL_DLOPEN=0 in Github Actions linux build
cengique Jan 20, 2025
2357340
more specific include of local curl headers
cengique Jan 20, 2025
28ab20a
Upgrade to MacOS 13
cengique Jan 20, 2025
a6361eb
Correct typo
cengique Jan 20, 2025
c407cb0
Updated copyright notice
cengique Jan 20, 2025
b1b1693
Update .github/workflows/build-macos.yml
cengique Jan 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@ build
Makefile.local
*.swp
*tags
misc/patches
misc/last-merged-ioq3-revision.temp
TAGS
*~

# CMake
CMakeCache.txt
CMakeFiles/

# OS X
####################
.Spotlight-V100/
Expand Down
90 changes: 78 additions & 12 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -111,28 +111,44 @@ ifndef VERSION
VERSION=1.3.0
endif

ifndef PACKAGE
PACKAGE=tremulous-grangerhub
endif

ifndef CLIENTBIN
CLIENTBIN=tremulous
endif

ifndef CLIENTBINSH
CLIENTBINSH=$(CLIENTBIN).sh
endif

ifndef SERVERBIN
SERVERBIN=tremded
endif

ifndef SERVERBINSH
SERVERBINSH=$(SERVERBIN).sh
endif

ifndef BASEGAME
BASEGAME=gpp
endif

BASEGAME_CFLAGS=-I../../${MOUNT_DIR}

ifndef COPYDIR
COPYDIR="/usr/local/games/tremulous"
COPYDIR="/opt/$(PACKAGE)"
cengique marked this conversation as resolved.
Show resolved Hide resolved
endif

ifndef COPYBINDIR
COPYBINDIR=$(COPYDIR)
endif

ifndef PREFIX
PREFIX=/usr
endif

ifndef MOUNT_DIR
MOUNT_DIR=src
endif
Expand Down Expand Up @@ -256,6 +272,11 @@ endif
BD=$(BUILD_DIR)/debug-$(PLATFORM)-$(ARCH)
BR=$(BUILD_DIR)/release-$(PLATFORM)-$(ARCH)

# If build target not defined, assume release (for install target)
ifndef B
B = $(BR)
endif

CDIR=$(MOUNT_DIR)/client
SDIR=$(MOUNT_DIR)/server
RCOMMONDIR=$(MOUNT_DIR)/renderercommon
Expand Down Expand Up @@ -339,8 +360,10 @@ INSTALL=install
MKDIR=mkdir
EXTRA_FILES=
CLIENT_EXTRA_FILES=
INSTALL_DIR=

ifneq (,$(findstring "$(PLATFORM)", "linux" "gnu_kfreebsd" "kfreebsd-gnu" "gnu"))
INSTALL_DIR=/opt/tremulous-grangerhub
BASE_CFLAGS += -DUSE_ICON
CLIENT_CFLAGS += $(SDL_CFLAGS)

Expand Down Expand Up @@ -1225,14 +1248,15 @@ endif
@echo " Output:"
$(call print_list, $(NAKED_TARGETS))
@echo ""
@$(MAKE) $(TARGETS) $(B).zip V=$(V)
@$(MAKE) $(TARGETS) $(B).zip $(B)/$(CLIENTBINSH) $(B)/$(SERVERBINSH) V=$(V)

$(B).zip: $(TARGETS)
ifeq ($(PLATFORM),darwin)
@("./make-macosx-app.sh" release $(ARCH); if [ "$$?" -eq 0 ] && [ -d "$(B)/Tremulous.app" ]; then rm -f $@; cd $(B) && zip --symlinks -r9 ../../$@ GPL COPYING CC `find "Tremulous.app" -print | sed -e "s!$(B)/!!g"`; else rm -f $@; cd $(B) && zip -r9 ../../$@ $(NAKED_TARGETS); fi)
@("./make-macosx-app.sh" release $(ARCH); if [ "$$?" -eq 0 ] && [ -d "$(B)/Tremulous.app" ]; then rm -f $@; cd $(B) && zip --symlinks -qr9 ../../$@ GPL COPYING CC `find "Tremulous.app" -print | sed -e "s!$(B)/!!g"`; else rm -f $@; cd $(B) && zip -qr9 ../../$@ $(NAKED_TARGETS); fi)
else
@rm -f $@
@(cd $(B) && zip -r9 ../../$@ $(NAKED_TARGETS))
@(cd $(B) && zip -qr9 ../../$@ $(NAKED_TARGETS))
@echo "Created $@"
endif

makedirs:
Expand Down Expand Up @@ -2616,18 +2640,21 @@ $(B)/$(BASEGAME)_11/vm/ui.qvm: $(UIVMOBJ11) $(UIDIR)/ui_syscalls_11.asm $(Q3ASM)
#############################################################################

$(B)/$(BASEGAME)/vms-gpp-$(VERSION).pk3: $(B)/$(BASEGAME)/vm/ui.qvm $(B)/$(BASEGAME)/vm/cgame.qvm $(B)/$(BASEGAME)/vm/game.qvm
@(cd $(B)/$(BASEGAME) && zip -r vms-$(VERSION).pk3 vm/)
$(echo_cmd) "Created $@"
@(cd $(B)/$(BASEGAME) && zip -qr $(@F) vm/)

$(B)/$(BASEGAME)_11/vms-1.1.0-$(VERSION).pk3: $(B)/$(BASEGAME)_11/vm/ui.qvm $(B)/$(BASEGAME)_11/vm/cgame.qvm
@(cd $(B)/$(BASEGAME)_11 && zip -r vms-$(VERSION).pk3 vm/)
$(echo_cmd) "Created $@"
@(cd $(B)/$(BASEGAME)_11 && zip -qr $(@F) vm/)


#############################################################################
## Assets Package
#############################################################################

$(B)/$(BASEGAME)/data-$(VERSION).pk3: $(ASSETS_DIR)/ui/main.menu
@(cd $(ASSETS_DIR) && zip -r data-$(VERSION).pk3 *)
$(echo_cmd) "Created $@"
@(cd $(ASSETS_DIR) && zip -qr data-$(VERSION).pk3 *)
@mv $(ASSETS_DIR)/data-$(VERSION).pk3 $(B)/$(BASEGAME)

#############################################################################
Expand Down Expand Up @@ -2904,6 +2931,43 @@ distclean: clean toolsclean
dist:
git archive --format zip --output $(CLIENTBIN)-$(VERSION).zip HEAD

#############################################################################
# INSTALL (only for Linux platforms)
#############################################################################

# Shell scripts for running binaries

$(B)/$(CLIENTBINSH):
@echo '#!/usr/bin/env sh' > $@
@echo 'cd $(COPYBINDIR)' >> $@
@echo './$(CLIENTBIN) "$$@"' >> $@

$(B)/$(SERVERBINSH):
@echo '#!/usr/bin/env sh' > $@
@echo 'cd $(COPYBINDIR)' >> $@
@echo './$(SERVERBIN) "$$@"' >> $@

# Install the .desktop, icon files, license, etc.
install: release
ifneq (,$(findstring "$(PLATFORM)", "linux" "gnu_kfreebsd" "kfreebsd-gnu" "gnu"))
$(echo_cmd) "Installing for Linux platform in $(COPYBINDIR) and $(PREFIX)"
@$(INSTALL) -d $(PREFIX)/bin "$(PREFIX)/share/metainfo/" \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a very small nitpick here. I noticed that some paths have "/" at their end and some don't. It does not matter, but it would still be nice to make it consistent.

"$(PREFIX)/share/licenses/$(PACKAGE)/" "$(PREFIX)/share/applications/" \
"$(PREFIX)/share/icons/hicolor/128x128/apps" "$(COPYBINDIR)"
@cd $(BR) && for file in $(NAKED_TARGETS); do \
$(INSTALL) -D $$file $(COPYBINDIR)/$$file; \
done
$(INSTALL) -D -m755 $(BR)/$(CLIENTBINSH) $(PREFIX)/bin/tremulous-grangerhub
cengique marked this conversation as resolved.
Show resolved Hide resolved
cengique marked this conversation as resolved.
Show resolved Hide resolved
$(INSTALL) -D -m755 $(BR)/$(SERVERBINSH) $(PREFIX)/bin/tremded-grangerhub
$(INSTALL) -D -m644 "misc/Tremulous-Grangerhub.png" "$(PREFIX)/share/icons/hicolor/128x128/apps/"
$(INSTALL) -D -m644 "misc/Tremulous-Grangerhub.desktop" \
cengique marked this conversation as resolved.
Show resolved Hide resolved
"$(PREFIX)/share/applications/"
$(INSTALL) -D -m644 "misc/io.github.grangerhub.Tremulous.appdata.xml" \
"$(PREFIX)/share/metainfo/"
$(INSTALL) -D -m644 "COPYING" "GPL" "CC" "$(PREFIX)/share/licenses/$(PACKAGE)/"
endif


#############################################################################
# DEPENDENCIES
#############################################################################
Expand All @@ -2917,11 +2981,13 @@ endif
.PHONY: all clean clean2 clean-debug clean-release \
debug default dist distclean makedirs release targets \
toolsclean toolsclean2 toolsclean-debug toolsclean-release \
$(OBJ_D_FILES) $(TOOLSOBJ_D_FILES) $(B)/scripts \
$(B)/$(BASEGAME)/data-$(VERSION).pk3 \
$(B)/$(BASEGAME)_11/vms-$(VERSION).pk3 \
$(B)/$(BASEGAME)/vms-$(VERSION).pk3 \
$(B).zip
$(OBJ_D_FILES) $(TOOLSOBJ_D_FILES) $(B)/scripts

# removing zip files from phony for install target not recreating them as root
# $(B)/$(BASEGAME)/data-$(VERSION).pk3 \
# $(B)/$(BASEGAME)_11/vms-$(VERSION).pk3 \
# $(B)/$(BASEGAME)/vms-$(VERSION).pk3 \
# $(B).zip

# If the target name contains "clean", don't do a parallel build
ifneq ($(findstring clean, $(MAKECMDGOALS)),)
Expand Down
Binary file added misc/Tremulous-Grangerhub-alt.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions misc/Tremulous-Grangerhub.desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
[Desktop Entry]
Name=Tremulous
Comment=Aliens vs Humans, First Person Shooter game with elements of Real Time Strategy
Icon=io.github.grangerhub.Tremulous
Copy link

@AsciiWolf AsciiWolf Jun 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you really want to use the "Tremulous-Grangerhub" naming scheme (which I disagree with as I mentioned), you need to fix the Icon name here as well.

Exec=tremulous
Terminal=false
Type=Application
Categories=Game;ActionGame;StrategyGame;Shooter;
PrefersNonDefaultGPU=true
Binary file added misc/Tremulous-Grangerhub.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/grangerhub-logo.png
cengique marked this conversation as resolved.
Show resolved Hide resolved
cengique marked this conversation as resolved.
Show resolved Hide resolved
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
71 changes: 71 additions & 0 deletions misc/io.github.grangerhub.Tremulous.appdata.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- Copyright 2017 Daniel Rusek <mail@asciiwolf.com> -->
cengique marked this conversation as resolved.
Show resolved Hide resolved
<component type="desktop-application">
<id>io.github.grangerhub.Tremulous</id>
<project_license>GPL-2.0</project_license>
<metadata_license>CC-BY-SA-3.0</metadata_license>
<provides>
<id>tremulous.desktop</id>
</provides>
<launchable type="desktop-id">Tremulous-Grangerhub.desktop</launchable>
cengique marked this conversation as resolved.
Show resolved Hide resolved
<name>Tremulous-Grangerhub</name>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? This will only make it confusing for our users. You can instead mention in the description that this is a "Grangerhub version of Tremulous". And it will add me much work to do to adjust the Flatpak to this unnecessary change. :-/

<developer_name>Dark Legion Development and GrangerHub</developer_name>
<summary>Aliens vs Humans, First Person Shooter game with elements of Real Time Strategy</summary>
<description>
<p>
Tremulous is a free, open source game that blends a team based FPS with
elements of an RTS.
</p>
<p>
Players can choose from 2 unique races, aliens and humans.
Players on both teams are able to build working structures in-game like an
RTS.
</p>
cengique marked this conversation as resolved.
Show resolved Hide resolved
<p>
This snap provides the Grangerhub updated client binary that
supports new features.
</p>
cengique marked this conversation as resolved.
Show resolved Hide resolved
</description>
<url type="homepage">https://github.com/GrangerHub/tremulous</url>
<screenshots>
cengique marked this conversation as resolved.
Show resolved Hide resolved
<screenshot type="default">
<image type="source" width="1280" height="960">https://raw.githubusercontent.com/GrangerHub/tremulous/master/misc/grangerhub-trem1.3-7d1b.jpg</image>
<caption>Tremulous 1.3 development with shadows</caption>
</screenshot>
<screenshot>
<image type="source" width="1366" height="768">https://raw.githubusercontent.com/GrangerHub/tremulous/master/misc/grangerhub-trem1.3-7672.jpg</image>
<caption>Tremulous 1.3 alien dragoon jumping over human player with portal gun</caption>
</screenshot>
<screenshot>
<image type="source" width="1366" height="768">https://raw.githubusercontent.com/GrangerHub/tremulous/master/misc/grangerhub-trem1.3-ca9d.jpg</image>
<caption>Human shooting alien acid tube with laser gun</caption>
</screenshot>
<screenshot>
<image type="source" width="1366" height="768">https://raw.githubusercontent.com/GrangerHub/tremulous/master/misc/grangerhub-trem1.3-7628.jpg</image>
<caption>Human base with medistation and armory</caption>
</screenshot>
<screenshot>
<image type="source" width="1366" height="768">https://raw.githubusercontent.com/GrangerHub/tremulous/master/misc/grangerhub-trem1.3-6d22.jpg</image>
<caption>Human with jetpack</caption>
</screenshot>
<screenshot>
<image type="source" width="1366" height="768">https://raw.githubusercontent.com/GrangerHub/tremulous/master/misc/grangerhub-trem1.3-e81b.jpg</image>
<caption>Human outside in ATCS map</caption>
</screenshot>
<screenshot>
<video>https://raw.githubusercontent.com/GrangerHub/tremulous/master/misc/videos/GrangerPub_Quick_Transit_Match-NewSource~tremulousrussian.mkv</video>
<caption>Quick match in Transit map. Credit: NewSource/TremulousRussian</caption>
</screenshot>
<screenshot>
<video>https://raw.githubusercontent.com/GrangerHub/tremulous/master/misc/videos/Tremulous_GPP_alien_gameplay-ZdrytchX~ViruS.webm</video>
<caption>Tremulous GPP alien gameplay. Credit: ZdrytchX/ViruS</caption>
</screenshot>
</screenshots>
<update_contact>mail@asciiwolf.com</update_contact>
<content_rating type="oars-1.1">
<content_attribute id="violence-fantasy">moderate</content_attribute>
<content_attribute id="violence-realistic">moderate</content_attribute>
<content_attribute id="violence-bloodshed">mild</content_attribute>
<content_attribute id="social-chat">intense</content_attribute>
</content_rating>
</component>
Binary file added misc/screenshots/grangerhub-misc-15.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/screenshots/grangerhub-misc-2.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/screenshots/grangerhub-trem1.3-292e.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/screenshots/grangerhub-trem1.3-3966.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/screenshots/grangerhub-trem1.3-4e0b.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/screenshots/grangerhub-trem1.3-506b.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/screenshots/grangerhub-trem1.3-5968.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/screenshots/grangerhub-trem1.3-6d22.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/screenshots/grangerhub-trem1.3-7628.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/screenshots/grangerhub-trem1.3-7672.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/screenshots/grangerhub-trem1.3-7d1b.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/screenshots/grangerhub-trem1.3-b263.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/screenshots/grangerhub-trem1.3-c5dc.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/screenshots/grangerhub-trem1.3-ca9d.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/screenshots/grangerhub-trem1.3-d10d.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/screenshots/grangerhub-trem1.3-e81b.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/screenshots/grangerhub-trem1.3-ea1c.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/screenshots/grangerhub-trem1.3-efaf.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added misc/screenshots/grangerhub-trem1.3-f2b7.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Loading