Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better idling for metatileentities and multiblocks #1554

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
c6454cc
Reworked trySearchNewRecipe and findRecipe
PrototypeTrousers Mar 15, 2021
9c622be
rework logic
PrototypeTrousers Mar 15, 2021
3c0e6f1
Refactor trySearchNewRecipe; add test to show issue re: lastItemOutputs
Exaxxion Mar 16, 2021
2655473
Changed item merging from full inventory copy to partial stacks copy
PrototypeTrousers Mar 25, 2021
27f4700
Implement notifiable item/fluid handlers
PrototypeTrousers Mar 30, 2021
1146268
enable the recipe logic to make use of the notifiable handlers
PrototypeTrousers Mar 30, 2021
ba882ee
address issues bought up on discussion
PrototypeTrousers Mar 31, 2021
5c8815d
made a declaration more obvious and with more detailed explanation
PrototypeTrousers Mar 31, 2021
281cabc
reverted change due to NPE
PrototypeTrousers Mar 31, 2021
d2a0a7d
fix multismelter getting stuck when its output gets full
PrototypeTrousers Apr 2, 2021
268a938
switched from HashSet to ArrayList.
PrototypeTrousers Apr 2, 2021
3b6cd4c
switch to a linked list
PrototypeTrousers Apr 9, 2021
279dd31
Simplified handler logic by only allowing one metatile to be notified
PrototypeTrousers Apr 11, 2021
e634951
address issues brought up
PrototypeTrousers May 25, 2021
8d04e76
Revert "Changed item merging from full inventory copy to partial stac…
PrototypeTrousers Mar 25, 2021
063a3e5
pass handlers around instead of a boolean
PrototypeTrousers May 29, 2021
84a29ae
fix tests due to world being null
PrototypeTrousers May 29, 2021
381d009
formatting
PrototypeTrousers May 30, 2021
754e1b4
update javadoc
PrototypeTrousers May 30, 2021
698d225
simplify logic
PrototypeTrousers Jun 2, 2021
694d97b
match deprecated behaviour
PrototypeTrousers Jun 5, 2021
b424b73
fix merge conflict
PrototypeTrousers Jun 5, 2021
36ac872
removed unnecesarry override and imports
PrototypeTrousers Jun 5, 2021
4eaff0f
address reviewed issues
PrototypeTrousers Jun 6, 2021
dfd6617
Add notifiable handlers to steam variant of metaTileEntities
PrototypeTrousers Jun 6, 2021
c847713
make the if statements more readable
PrototypeTrousers Jul 22, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
match deprecated behaviour
PrototypeTrousers committed Jul 22, 2021

Unverified

The email in this signature doesn’t match the committer email.
commit 694d97bbe1cb8b92d8fc357807025707df8bfdc6
Original file line number Diff line number Diff line change
@@ -238,7 +238,10 @@ protected Recipe findRecipe(long maxVoltage, IItemHandlerModifiable inputs, IMul
*/
@Deprecated
PrototypeTrousers marked this conversation as resolved.
Show resolved Hide resolved
protected boolean checkRecipeInputsDirty(IItemHandler inputs, IMultipleTankHandler fluidInputs) {
return this.hasNotifiedInputs();
boolean isDirty = this.hasNotifiedInputs();
metaTileEntity.getNotifiedItemInputList().clear();
metaTileEntity.getNotifiedFluidInputList().clear();
return isDirty;
}

protected static boolean areItemStacksEqual(ItemStack stackA, ItemStack stackB) {