Attempt to fix crash with only plasma fluid #2295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes a crash when a material is only generating a plasma. The crash would arise because the plasma would not be finished generating, therefor calling
material.getFluidwould NPE. Therefore, if there is a queued builder for the material, we will fetch the material from there.I am not really sure about this fix, as I don't konw if it is correct to be passing in
getPrimaryKey, because it is nullable, and because I don't know if that would reference plasma for a plasma only fluid.Outcome
Fixes a crash with plasma only materials