fix: introduce gc task for metadata store #5461
Open
+80
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
requested review from
waynexia,
v0y4g3r,
MichaelScofield and
a team
as code owners
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
WenyXu
force-pushed
the
fix/metadata-kvbackend-gc-task
branch
from
c3cb50c to
e7a627d
Compare
There was a problem hiding this comment.
Copilot reviewed 6 out of 13 changed files in this pull request and generated no comments.
Files not reviewed (7)
- config/standalone.example.toml: Evaluated as low risk
- src/cmd/src/standalone.rs: Evaluated as low risk
- src/common/config/src/lib.rs: Evaluated as low risk
- src/frontend/src/instance.rs: Evaluated as low risk
- src/log-store/Cargo.toml: Evaluated as low risk
- src/common/procedure/src/options.rs: Evaluated as low risk
- src/frontend/Cargo.toml: Evaluated as low risk
v0y4g3r
approved these changes
Jan 27, 2025
| @@ -19,7 +19,7 @@ use std::time::Duration; | |||
| use common_base::readable_size::ReadableSize; | |||
| use serde::{Deserialize, Serialize}; | |||
|
|
|||
| #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)] | |||
| #[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)] | |||
There was a problem hiding this comment.
We can remove some clone of ProducerConfig since we've derived Copy for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
PR Checklist
Please convert it to a draft if some of the following conditions are not met.