Generate only kpis #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameters easily from main
…o also be used when only running mode KPI
…ence data is provided
…sts, only the one related to a test
…ng from an existing generated data folder such as a grid2op env
…ifferent starting dates accross scenarios when generating kpis from existing generated data
…refer to the one from input user
…rated data and sometimes not
…lready generated or being generated to look for the chronic folder
BDonnot
requested changes
Apr 11, 2023
There was a problem hiding this comment.
I think some changes need to be made before merging, most notably:
- the plt.ioff() or something like that, which can have side effects impossible to find and debug
- the requirements.txt that uses completely outdated library (in the branch
ramp_forecastsi made the changes to use most recent versions and tests pass, maybe we could merge this branch first ?) - some minor readability issues with the
if not
tests/data/input/generation/case118_l2rpn_wcci_2022/gen_info.txt
Outdated
Show resolved
Hide resolved
tests/data/input/generation/case118_l2rpn_wcci_2022/remove_load.py
Outdated
Show resolved
Hide resolved
…rrors in new versions
|
@BDonnot thanks for the long review, I addressed all comments and merged master into it to be up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now generate KPIs based on existing data as with this cli
You can also only generate KPIs for your generated data if you don't want to bother generating KPIs for some reference data. This can be done by setting in ParamsKPI.json