feat: add ftdetect for .props

[molostovvs]

When working with Directory.Build.props or Directory.Packages.props files, it is annoying that the file type is not detected, which makes commenting plugins and syntax highlighting not work.

[GustavEikaas]

Awesome, thanks for making a PR. I have also missed this previously!❤️❤️

I do worry that this might interfere with other non-dotnet scenarios. We should consider the following.

1. Could we use the is_dotnet_project() function upon VimEnter to enable this?
2. Could we add a property to options for enabling/disabling this, in case it interferes with other scenarios

Thoughts? We could also merge it and wait for possible issues on this before implementing some variant of the options above

[GustavEikaas]

enable_filetypes

[molostovvs]

Hi! Sorry I didn't reply to the comment. the original implementation was taken from go.nvim (where just filetype.vim is used), but the feature toggle approach looks better.

Now I'm not sure how to properly implement the project type check once to create autocmd once, and how not to set filetype in the buffer without closing it (i.e. avoid setting filetype when :e is used).

[GustavEikaas]

Now I'm not sure how to properly implement the project type check once to create autocmd once, and how not to set filetype in the buffer without closing it (i.e. avoid setting filetype when :e is used).

Im on vacation without a computer until Friday so probably wont be able to merge before then. Hmm have you tried BufReadPost? Is there any drawbacks or side-effects when setting filetype multiple times?

[GustavEikaas]

Havent tested extensively but this seems to work for me, only creates the autocmd once and only sets the filetype once per buffer.

local M = {}

M.enable_filetypes = function()
  vim.api.nvim_create_autocmd({ "BufReadPost" }, {
    pattern = "*.props",
    group = vim.api.nvim_create_augroup("solution_props", { clear = true }),
    callback = function()
      vim.bo.filetype = "xml"
    end,
  })
end

return M

[GustavEikaas]

Messed around in some other vim plugins today and came across this. Seems to be working and be the best and easiest solution

local M = {}

M.enable_filetypes = function()
  vim.filetype.add({
    extension = {
      props = "xml",
    },
  })
end

return M

[GustavEikaas]

Didnt mean to hijack your PR. Let me know if you disagree with the changes

[GustavEikaas]

We should extend this to also add xml for slnx, #220

[GustavEikaas]

I upstreamed these file type changes to the official vim repository.

Msbuild: 32b7e3a
Slnx: 3b3318b

We can still merge this PR as it will take a while for this change to propagate to everyones nvim installation

[GustavEikaas]

Adding icons to nvim-web-devicons also

• feat: add slnx icon nvim-tree/nvim-web-devicons#536
• feat: add msbuild configuration icons nvim-tree/nvim-web-devicons#537