TimePicker now defaults in hour24 mode to value as in am mode. #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can setStartTime(date) or stStartTime(string) as start time if value isn't set.
|
Ok I think this is a good feature. Could we not just refactor the current code format - as we used standard format to all widgets. If you can change that then we can merge this request. |
|
Thanks for the positive feedback. However, I'm not sure how to help to refactor the code. Can you give me a hint for this? I'd really like to contribute to this great project. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem with timepicker in hour24 mode: It always did default to now() - isValidTime failed in timepicker.js
This is now solved.
And you can setStartTime(date) or setStartTime(string) as start time if value
isn't set.