Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for version 1.0.0 #2

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

kreczko
Copy link
Member

@kreczko kreczko commented Jul 27, 2020

No description provided.

@kreczko
Copy link
Member Author

kreczko commented Jul 27, 2020

@fschaer any objections to these changes?
The most relevant one is 30ddd75 which is a rewrite of the randompass function in modern Ruby

@fschaer
Copy link

fschaer commented Jul 27, 2020 via email

@kreczko kreczko force-pushed the kreczko-version-1.0.0-prep branch from a9cb4e1 to 8fd23cd Compare July 27, 2020 15:14
@kreczko
Copy link
Member Author

kreczko commented Jul 27, 2020

Thanks for the quick reply. Params is only used in argus::servicecert it seems, so easy to remove - done in 8fd23cd.

As for the params change: that changed from params to argus::params for the servicecert in your PR. Sorry, missed that one too :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants