Skip to content

Commit

Permalink
FHIR-46501 - Consider changing example instances to follow best pract…
Browse files Browse the repository at this point in the history
…ice for UCUM and avoid using curly braces.
  • Loading branch information
rhausam committed Jul 31, 2024
1 parent 48a6a96 commit e73561b
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
2 changes: 1 addition & 1 deletion input/fsh/instances/medication-39-07-1.fsh
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ Usage: #example
* form.coding[+] = $standardterms#10219000 "Tablet"
* ingredient.itemCodeableConcept = $rxnorm#36567 "Simvastatin"
* ingredient.strength.numerator = 40 'mg' "mcg"
* ingredient.strength.denominator = 1 '{tablet}' "tablet"
* ingredient.strength.denominator = 1 '1' "tablet"
2 changes: 1 addition & 1 deletion input/fsh/instances/observation-alcoholuse-1.fsh
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ Usage: #example
* subject = Reference(patient-example-female)
* effectiveDateTime = "2019-07-15"
* performer = Reference(eumfh-39-07)
* valueQuantity = 2 '{wine glasses}/d' "wine glasses per day"
* valueQuantity = 2 '/d' "wine glasses per day"
4 changes: 0 additions & 4 deletions input/ignoreWarnings.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ INFORMATION: Immunization/75680: Immunization.vaccineCode.coding[2].system: A de
# The EDQM codesystem has properties not known to FHIR publication tooling
%No definition can be found for the system http://standardterms.edqm.eu, and the property%

# UCUM coding has been reviewed and decision to retain information inside curly brackets
WARNING: Medication/eumfh-39-07-1: Medication.ingredient[0].strength.denominator: UCUM Codes that contain human readable annotations like {tablet} can be misleading (e.g. they are ignored when comparing units). Best Practice is not to depend on annotations in the UCUM code, so this usage should be checked
WARNING: Observation/alcohol-use-example: Observation.value.ofType(Quantity): UCUM Codes that contain human readable annotations like {wine glasses} can be misleading (e.g. they are ignored when comparing units). Best Practice is not to depend on annotations in the UCUM code, so this usage should be checked

# It is not possible to include examples on datatypes (oddly this error does not arise on other datatypes which lack examples)
WARNING: StructureDefinition.where(url = 'http://hl7.org/fhir/uv/ips/StructureDefinition/Range-uv-ips'): The Implementation Guide contains no examples for this data type profile
WARNING: StructureDefinition.where(url = 'http://hl7.org/fhir/uv/ips/StructureDefinition/SimpleQuantity-uv-ips'): The Implementation Guide contains no examples for this data type profile

0 comments on commit e73561b

Please sign in to comment.