[Ko-translation] Scaffold Korean translation environment #929
Conversation
There was a problem hiding this comment.
Hi @techhtml made a few comments for some of the files.
For most of the rest of the files they should not exist yet.
For templates/ko/2019 and content/ko/2020, please only create these files as they are translated. Do not put in the English versions in the ko folder. The way the site works is it recognises if a chapter is missing and has special logic to only show chapters. For example the JavaScript chapter is only available in English, Spanish and Japanese but not French:
For the 2020 files, this is very much just kicking off now and they are likely to change a lot so don't create ko versions just yet as will just give us more to maintain. Will let you know when 2020 has settled down and you're good to start creating the files.
Once you remove those files, the rest could be merged, but best to include translations of these core necessary files in first PR as discussed here
- base.html
- base_chapter.html
- index.html
- table_of_contents.html
| @@ -2,7 +2,7 @@ | |||
| "settings": [ | |||
| { | |||
| "is_live": true, | |||
| "supported_languages": ["en","es","fr","ja"], | |||
| "supported_languages": ["en","es","fr","ja","ko"], | |||
There was a problem hiding this comment.
| "supported_languages": ["en","es","fr","ja","ko"], | |
| "supported_languages": ["en","es","fr","ja"], |
Once it's in this config, it will be live on the next release so can we keep it out of this config for now? At least until we have a chapter or two to launch.
| @@ -2,7 +2,7 @@ | |||
| "settings": [ | |||
| { | |||
| "is_live": false, | |||
| "supported_languages": ["en","es","fr","ja"], | |||
| "supported_languages": ["en","es","fr","ja", "ko"], | |||
There was a problem hiding this comment.
It's OK to leave in here for now as 2020 is not live yet. But we'll probably remove it later as probably will launch English first.
| @@ -0,0 +1 @@ | |||
| This is the directory in which content teams add the markdown version of their chapters. | |||
There was a problem hiding this comment.
Hmmm... this file shouldn't exist. But see it does exist for English directory. It shouldn't so will remove. Can you remove this ko file?
|
I got it. I will fix it (I just copied all the files). Thank you! |
|
Close this PR and I'd re-start scaffold this weekend. |
Related with #926
I had created a Korean translation environment.