Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat "(cid:%d)" as a possible char to reduce "Out of order" warnings #102

Merged
merged 3 commits into from
Oct 28, 2020

Conversation

HiromuHota
Copy link
Contributor

@HiromuHota HiromuHota commented Oct 28, 2020

Description of the problems or issues

Is your pull request related to a problem? Please describe.

Related to #33, currently pdftotree produces CID characters like (cid:176).
This is now totally expected behaviour of pdftotree, so "Out of order warning" should not be raised.

Does your pull request fix any issue.

N/A

Description of the proposed changes

Treat "(cid:%d)" as a possible char

Test plan

Test with paleo.pdf that produces "Out of order" warnings

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the CHANGELOG.md accordingly.

@codecov-io
Copy link

Codecov Report

Merging #102 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   66.83%   66.83%   -0.01%     
==========================================
  Files          24       24              
  Lines        2593     2596       +3     
==========================================
+ Hits         1733     1735       +2     
- Misses        860      861       +1     
Flag Coverage Δ
#unittests 66.83% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pdftotree/TreeExtract.py 89.26% <100.00%> (-0.28%) ⬇️
tests/test_basic.py 96.10% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7e38be...36bc8a5. Read the comment docs.

@HiromuHota HiromuHota marked this pull request as ready for review October 28, 2020 22:08
@HiromuHota HiromuHota merged commit 06d5112 into HazyResearch:master Oct 28, 2020
@HiromuHota HiromuHota deleted the suppress/outoforder branch October 28, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants