Implement more of the CLI #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AislingHPE
force-pushed
the
fix-cli-a-bit
branch
from
f22bfa9 to
ec92951
Compare
Next up is adding slog and slog options. Also adding unit tests for some of the options. This PR adds `--output`,`--overwrite`, `--stdout` and `--allow-empty` and implements each of them. There are some edge cases I need to cover with logging and the `stdout` option, but otherwise this is a first draft of the 'complete' CLI.
cmd.go now prints usage when a flag error occurs, and is structured so that it throws around fewer global variables.
AislingHPE
force-pushed
the
fix-cli-a-bit
branch
from
ec92951 to
5c49276
Compare
eamonnotoole
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds --output,--overwrite, --stdout and --allow-empty and implements each of them. There are some edge cases I need to cover with logging and the stdout option, but otherwise this is a first draft of the 'complete' CLI.