generated from spatie/package-skeleton-php
-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toLocaleString() method to array #47
Open
xanaDev
wants to merge
12
commits into
Hi-Folks:main
Choose a base branch
from
xanaDev:feat/arr-to-local-string
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3e3b87b
doc: add toLocaleString() documentatio
xanaDev fbf2e51
test: add unit tests for toLocaleString()
xanaDev e234332
feat: implement toLocaleString() method
xanaDev e45b6a1
chore: update CHANGELOG.md
xanaDev d624b1b
refactor: use existing helper to check for empty arrays
xanaDev a52c56e
fix: add type hints to function params
xanaDev 0b5288f
fix: use fallback locale if provided locale is not available
xanaDev affba46
test: update tests to account for unavailable locales
xanaDev 86627c0
fix: updates cheatsheet example
xanaDev 7b1419d
doc: update toLocaleString() docs
xanaDev 2f1074f
style: run composer format
xanaDev 3b5ed53
refactor: change helper to private
xanaDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, while this covers the
Date.prototype.toLocaleString()
there is also theObject.prototype.toLocaleString()
and theNumber.prototype.toLocalString()
that can be converted from theArray.protoype.toLocalString()
.Link to the other types of
toLocalString()
conversionshttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/toLocaleString#examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can definitely add support for the other methods, I'll update the current PR unless otherwise advised.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. if you want you can do it in this PR, or if you prefer you could close this and create another new PR with this refactor.
I mention "refactor" because this package is for Array so I would like to provide the toLocaleString for Arr (public method). The toLocaleString for other types (number and data) is for a clear code that is easier to test.