Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Found Page #60

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Not Found Page #60

wants to merge 5 commits into from

Conversation

JITESH-KUMAR05
Copy link

Summary:
This PR adds a custom 404 Not Found page to the project. The page includes a styled message and animated elements using GSAP.

Issue Link:
N/A

PR Checks:

  • Code is properly formatted (executed make pre-push command).
  • No ESLint warnings (verified with make pre-push command).
  • UI Changes are responsive (checked in the responsive view).
  • Performance is maintained (Lighthouse report reviewed).
  • User experience (UX) considerations are met.
  • Accessibility is supported (validated with accessibility tools).

Details:

  • Added a new not-found.jsx file to handle 404 errors.
  • Implemented a custom 404 page with a styled message and animated elements using GSAP.
  • Currently, the same image is used in all boxes. We should replace them with unique images if required.
  • There are 8 boxes visible instead of 4. This might be due to React's strict mode or another issue. Please review and suggest any necessary changes.

Please review the changes and let me know if there are any issues or further improvements needed.

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for pyconfhyd2025 ready!

Name Link
🔨 Latest commit 770f366
🔍 Latest deploy log https://app.netlify.com/sites/pyconfhyd2025/deploys/6787db2cad7e11000864eb0b
😎 Deploy Preview https://deploy-preview-60--pyconfhyd2025.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JITESH-KUMAR05
Copy link
Author

added not-found.jsx

@JITESH-KUMAR05
Copy link
Author

Now the deployment issue is fixed

@JITESH-KUMAR05
Copy link
Author

working and no deployment error

package.json Outdated Show resolved Hide resolved
src/app/not-found.jsx Outdated Show resolved Hide resolved
src/app/not-found.jsx Outdated Show resolved Hide resolved
@JITESH-KUMAR05
Copy link
Author

please do check it again if it's fine now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants