Sourcery Starbot ⭐ refactored Hyperclaw79/PokeBall-SelfBot-Poketwo-Autocatcher #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceryAI
commented
Mar 19, 2022
Comment on lines
-469
to
+471
| else: | ||
| for result in results[i:i+10]: | ||
| embed.add_field(name=result[0], value=f"**ID**: {result[1]}\n**LEVEL**: {result[2]}", inline=False) | ||
| embeds.append(embed) | ||
| for result in results[i:i+10]: | ||
| embed.add_field(name=result[0], value=f"**ID**: {result[1]}\n**LEVEL**: {result[2]}", inline=False) | ||
| embeds.append(embed) |
There was a problem hiding this comment.
Function PokeBall.cmd_id refactored with the following changes:
- Remove unnecessary else after guard condition (
remove-unnecessary-else)
Comment on lines
-495
to
+496
| limit = 2 | ||
| if args: | ||
| limit = int(args[0]) | ||
| limit = int(args[0]) if args else 2 | ||
| dups = {dup for dup in pokemons if pokemons.count(dup) >= limit} | ||
| if len(dups) == 0: | ||
| if not dups: |
There was a problem hiding this comment.
Function PokeBall.cmd_duplicates refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp) - Move setting of default value for variable into
elsebranch (introduce-default-else) - Simplify sequence comparison (
simplify-len-comparison)
Comment on lines
-656
to
+653
| for s in lines: | ||
| res.append('│ ' + (s + ' ' * width)[:width - 1] + '│') | ||
| res.extend('│ ' + (s + ' ' * width)[:width - 1] + '│' for s in lines) |
There was a problem hiding this comment.
Function PokeBall.on_ready.updater.bordered refactored with the following changes:
- Replace a for append loop with list extend (
for-append-to-extend)
|
Wow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: