feat(CIS): Logpush to cloud logs and generic destination #5872
+426
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Testing for Logpush jobs
|
hkantare
reviewed
Jan 17, 2025
| @@ -63,6 +73,57 @@ func ResourceIBMCISLogPushJob() *schema.Resource { | |||
| }, | |||
| Description: "Information to identify the LogDNA instance the data will be pushed.", | |||
| }, | |||
| cisLogPushCos: { | |||
| Type: schema.TypeString, | |||
There was a problem hiding this comment.
why we defined the type as string json can't we define it as list similar cisLogPushIbmCl
There was a problem hiding this comment.
So the attributes inside the Cos are not fixed like they are in IBMCL. In the end we have to send the data as json string only just like in cisLogdna. So i thought it would be better to use the already working approach.
hkantare
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing: