Skip to content

Commit

Permalink
Missing dereference of value, oddly perl 5.10 spots this at compile t…
Browse files Browse the repository at this point in the history
…ime but newer perl doesn't
  • Loading branch information
keiranmraine committed Apr 15, 2014
1 parent 9518748 commit 0a23254
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/PCAP/Bwa/Meta.pm
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ sub _init {
my ($self, $opts) = @_;
croak "'rg' is auto-populated, to initialise a start value see PCAP::Bwa::Meta::set_rg_index"
if(exists $opts->{'rg'});
for my $key(keys $opts) {
for my $key(keys %{$opts}) {
croak "'$key' is not a valid parameter for object initialisation" unless(first {$key eq $_} @INIT_KEYS);
croak "'$key' is not a scalar, only simple values are expected" if(ref $opts->{$key} ne q{});
$self->{$key} = $opts->{$key};
Expand Down

0 comments on commit 0a23254

Please sign in to comment.