Fixed Issue with Convert Numeric dialog not popping up #9341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdstern
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
@derekagorhom excellent detective work and very useful.
You say only partially fixes the issue. Is that just being cautious - it seems fixed to me?
@N-thony another bug sorted. Over to you to check and merge.
N-thony
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9325
While going through the issue i realized the
frmConvertoNumeric'scmdLabelledConvertalternates betweenlabelled convertandordinal convert. it seems theordinal convert optionworks because thefrmConvertoNumericis able to pop up when the column being converted to numeric is not labelled but does not for the case where column is labelled. This PR should fix that issue (I hope) without causing any regression.@rdstern , @N-thony can your review this PR
Thanks