-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional button in the Insert > Save Results Tab #9371
Additional button in the Insert > Save Results Tab #9371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derekagorhom great - it already works! So the suggestions are just cosmetic.
Here is the current dialog:
a) It should be From Variables: (so add the s)
b) Put the Name(s) and Data Frames on their own lines. I don't mind if the dialog is a bit longer - and can be longer for all options if needed.
c) Similarly put the From R file, below the Single checkbox, so the 3 buttons are each below and lined up.
d) In the comment that is generated, add a space before the into.
Thanks
@rdstern I have made the changes, can you review this again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derekagorhom great - that looks fine now
@N-thony over to you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derekagorhom I approved earleir, but please first add the s to Variable:, so it becomes Variables:
.
@rdstern I have made the change |
Fixes #9329
I have added the
From Variables
options with the twofields
to complete@rdstern , @N-thony
This is ready for review