Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Rust language #102

Open
wants to merge 15 commits into
base: development
Choose a base branch
from

Conversation

royalpinto007
Copy link

Implemented support for the Rust programming language, which previously had not been available in the extension. The necessary changes have been applied.

adityachirania and others added 13 commits March 23, 2022 11:13
Currently only running testcases with compilation flags is allowed in haskell.
Stress Testing has not been added due to difficulty with System.Random package
Add Haskell support and fix testcase parsing
Implemented support for the Rust programming language, which previously had not been available in the extension. The necessary changes have been applied.
@Dragonado Dragonado self-requested a review January 22, 2023 13:55
Copy link
Collaborator

@Dragonado Dragonado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change your branch to "development" and make a pull request for IEEE-NITK:development. I will merge dev branch to master branch if the code passes all reviews

package.json Outdated
@@ -542,6 +549,7 @@
"cheerio": "^1.0.0-rc.10",
"child_process": "^1.0.2",
"fs": "^0.0.1-security",
"node-fetch": "^2.6.1"
"node-fetch": "^2.6.1",
"problem-matcher": "^1.1.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "problem matcher" dependency

Copy link
Author

@royalpinto007 royalpinto007 Jan 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency has been removed. (397baf0)

@@ -90,6 +90,17 @@ export const runTestsWithTimeout = async (
? "java.exe"
: "java";
break;
case CompilationLanguages.rust:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire block of code is not necessary. You can move "case CompilationLanguages.rust:" to below the c/cpp/haskell case block

Copy link
Author

@royalpinto007 royalpinto007 Jan 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the necessary adjustments. (a2a2175)

I added the rust compilation code to an existing case instead of creating a new one, as it could have been included in the c/cpp/haskell case, to avoid unnecessary duplication.
@royalpinto007 royalpinto007 changed the base branch from master to development January 22, 2023 16:02
@royalpinto007
Copy link
Author

Change your branch to "development" and make a pull request for IEEE-NITK:development. I will merge dev branch to master branch if the code passes all reviews

As requested, I switched the branch from master to development. Can you please take a look?

@royalpinto007 royalpinto007 changed the title Added support for the Rust language Add support for the Rust language Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants