-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Week2 Assignment prashant kumar choudhary #88
Open
Prashant-3103
wants to merge
5
commits into
IRIS-NITK:week2_assignment
Choose a base branch
from
Prashant-3103:week2_prashant_kumar_choudhary
base: week2_assignment
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6315288
Update prime_numbers.rb
Prashant-3103 3f26d3d
Updated pet.rb with solutions
Prashant-3103 1b54519
i updated prime.rb
Prashant-3103 42df0c0
i updated rrime.rb file
Prashant-3103 d56a6b3
updated my prime_number.rb file
Prashant-3103 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,18 +1,16 @@ | ||||||
# A prime number is a whole number greater than 1 | ||||||
# that cannot be exactly divided by any whole number | ||||||
# other than itself and 1 | ||||||
# (e.g. 2, 3, 5, 7, 11). | ||||||
|
||||||
# The function below takes a keyword arguments `n` and | ||||||
# returns an array of prime numbers less than or equal to | ||||||
# `n`. | ||||||
|
||||||
# For example, prime_numbers(n: 20) should return the following: | ||||||
# [2, 3, 5, 7, 11, 13, 17, 19] | ||||||
|
||||||
# If the user gives a invalid input like -4 | ||||||
# We will raise an `ArgumentError` exception to let the caller know that | ||||||
# their function arguments were incorrect. | ||||||
def prime_numbers(n:) | ||||||
raise NotImplementedError # TODO | ||||||
raise ArgumentError, "n must be greater than or equal to 2" if n < 2 | ||||||
|
||||||
primes = [] | ||||||
(2..n).each do |i| | ||||||
is_prime = true | ||||||
(2..Math.sqrt(i).ceil).each do |j| | ||||||
if i % j == 0 | ||||||
is_prime = false | ||||||
break | ||||||
end | ||||||
end | ||||||
primes << i if is_prime | ||||||
end | ||||||
puts primes | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. return the array.
Suggested change
|
||||||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
map
can also be used here.