Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support \fBIPR1234 and \c as constant escapes, \$[*1-9] as variable (macro arguments), .[ad]s and \*q/\*(Am/\*[name] #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nabijaczleweli
Copy link

Tentative half-support for macros. It's not perfect and it doesn't include the actual macros, but it makes macro definitions that much more readable

Before:
image

After:
image

@nabijaczleweli nabijaczleweli changed the title Support \fBIPR1234 and \c as constant escapes. Support \$[*1-9] as variable (macro arguments) Support \fBIPR1234 and \c as constant escapes, \$[*1-9] as variable (macro arguments), .[ad]s and \*q/\*(Am/\*[name] May 31, 2021
@nabijaczleweli
Copy link
Author

Strings:
image

And .[ad]s (slightly suboptimal, I guess, but better than nothing):
image

@ISSOtm
Copy link
Owner

ISSOtm commented May 31, 2021

Hi! I wasn't expecting contributions to this syntax, to be honest :P But thanks for the attention!

I've recieved feedback from the Sublime Text maintainers that using regex look-back actually impacts performance, and thus I've begun (but not finished yet due to lacking time) rewriting this syntax. The gist of it:

  • I do not intend to maintain the currently-published syntax anymore.
  • I have a partial rewrite, which should be more lightweight and correct (notably, in its handling of inline macros).

If you are interested, I can push that partial rewrite to a separate branch, and then you could rebase your PRs against it. (And, if you're interested, finish the grunt work in my place, though I'm certainly not gonna force that on you, thanks again for the PRs!)

If you aren't interested, I'll review the PRs against the current syntax; improvements are still worth taking.

@nabijaczleweli
Copy link
Author

I'm far from a Sublime syntax aficionado — these PRs were achieved by brute force until it looked okay – but I'll be happy to rebase them onto the new syntax, at the very least, yeah

@nabijaczleweli
Copy link
Author

Two-week bump, ICYMI

@ISSOtm
Copy link
Owner

ISSOtm commented Feb 18, 2023

Hi, sorry, somehow I didn't get notifications for your PRs, oops... does this (and the other ones) still apply to the new, overhauled syntax?

Apologies for the uh, year-long delay! ^^'

@nabijaczleweli
Copy link
Author

Dunno, that's broken entirely:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants