-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone 11: API Endpoints for user - post - comment #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ITurres and @demesameneshoa, 👋🏻👋🏻
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlights
- Followed Gitflow 💯
- Descriptive PR⭐
- No Linters error ✅
- Kudos for working on the API endpoints🤩
- Your design is amazing ⭐
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
@Reem-lab Hi Reem!, Thank you so much for taking the time to review our PR 🥳. We wish you a great weekend and happy programming! 👩🏼💻 |
@ITurres thank you so much, you are welcome anytime 🚀🔥, happy weekend |
Pull Request Summary for Milestone 11 Completion
Added:
/app/controllers/api/v1/application_controller.rb
/app/controllers/api/v1/comments_controller.rb
/app/controllers/api/v1/posts_controller.rb
/app/controllers/api/v1/users_controller.rb
Modified:
/Gemfile
and/Gemfile.lock
active_model_serializers
andresponders
gems to theGemfile
and ranbundle install
to update theGemfile.lock
./README.md
/app/models/comment.rb
as_json
to return the user_id, text, and comment id./app/models/post.rb
as_json
to return the id, title and the text./app/models/user.rb
ad_json
to retun id, name and bio./config/environments/development.rb
config.debug_exception_response_format
to:api
to show the error messages in the browser./config/routes.rb
Thank you for reviewing this PR. Feel free to reach out on Slack as Arturo (Arthur) Emanuel Guerra Iturres and/or Demes Ameneshoa for any queries or further assistance. 🌟