Milestone 6: views #6

ITurres · 2023-12-07T03:06:21Z

Pull Request Summary for Milestone 6 Completion

Added:

`/app/views/posts/_posts.html.erb`

Created a versatile partial to render either multiple posts or a single post based on the @posts variable.
Renders post content, comment and like counts, and display comments if available.

`/app/views/shared/_button_link.html.erb`

Implemented a simple reusable partial to render a button linked to any page.

`/app/views/shared/_user_card.html.erb`

Developed a partial responsible for displaying user information like name, photo, and post count. It links to user_path(user).

Modified:

`/README.md`

Marked the controllers specs task as completed.

`/Gemfile` and `/Gemfile.lock`

Added the faker gem for generating test data in development mode.

`/app/controllers/posts_controller.rb`

Modified index method to conditionally set @posts to display all posts or only those of the current user.
Adjusted show method to set @post for the current user's post.

`/app/controllers/users_controller.rb`

In index method, set @users to display all users.
Updated show method to set @user based on the current user's params.

`/app/views/layouts/application.html.erb`

Updated title, added viewport, description, and author meta tags, linked Bootstrap CDN, and included the app favicon.

`/app/views/posts/index.html.erb`

Modified the view to display all posts and utilized the shared/button_link partial for pagination.

`/app/views/posts/show.html.erb`

Renders the selected post using the posts partial.

`/app/views/users/index.html.erb`

Utilized the user_card partial to display all users.

`/app/views/users/show.html.erb`

Displays user information including name, bio, posts, and post comments using the user_card partial.
Included the shared/button_link partial to navigate to 'see all posts'.

Thank you for reviewing this PR. Feel free to reach out on Slack as Arturo (Arthur) Emanuel Guerra Iturres for any queries or further assistance. 🌟

- '#index' to fetch all users. - '#show' to find a user by id.

- Add max-width to main element. - Update partial path. - Add partial's local variables 'truncate_n' and 'limit_n'.

- Render 'user_card' partial. - Render 'posts' partial. - Render 'button_link' partial.

- Render 'posts' partial. - Wrap 'posts' partial in 'main'.

Olamarx

Hi @ITurres,

Good job so far, indeed you have spent time on this project!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Linters passed ✔️
Readme file professional ✔️
All views code works ✔️

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Olamarx · 2023-12-07T03:42:28Z

app/views/posts/_posts.html.erb

+    <% if limit_n > 0 %>
+      <div class="card card-body mt-1 p-3">
+        <ul class="list-unstyled">
+
+          <% post.most_recent_comments(limit_n).each do |comment| %>
+            <li><%= comment.author.name %>: <%= comment.text %></li>
+          <% end %>
+
+        </ul>
+      </div>
+    <% end %>


I could not confirm the comment because I ran into an error while trying to add data, others were added successfully but the comment failed to, I will encourage you to double-check it.

Hi @Olamarx! it is running well on my end! 🎯

It runs well on my end too, just the comments were not added.

@Olamarx, a short screencast

addind-data-to-blog-db-dev.webm

@Olamarx, the reason for the issue is that when instantiating the Comment model, it expects author as a parameter. However, in your instantiations, you're sending user instead of author.

i.e

Comment.create(post: first_post, author: first_user, text: 'Hi Tom!' )

MahmoudBakr23

Hi @ITurres 😃,

Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉

Highlights

Well done on working on this project so far. All is good. 💯

Cheers, and Happy coding!👏👏👏

Feel free to mention @MahmoudBakr23 to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

ITurres · 2023-12-07T16:17:32Z

Hello @MahmoudBakr23! thank you for having reviewed and approved the PR :D, have a good week!

ITurres added 20 commits December 6, 2023 15:01

Feat: Update PostsController#index to fetch user's posts

87d1122

Feat: Update 'UsersController' '#index' and '#show' actions

1949ee3

- '#index' to fetch all users. - '#show' to find a user by id.

Feat: Add meta tags and Bootstrap cdn to 'application.html.erb'

b13a81b

Add '_user_card.html.erb' shared partial

1c08e7f

Feat: Update 'User' 'index' and 'show' views

02c2338

RStyles: Remove inline flexbox from 'index.html.erb' -main-element-

9b96ee1

Feat: Update inline styles and partials data on 'user#show' page

abeaed0

- Add max-width to main element. - Update partial path. - Add partial's local variables 'truncate_n' and 'limit_n'.

Styles: update flexbox and card styles on 'user_card' partial

e05366d

Add posts '_posts.html.erb' partial

bdb3fef

Chore: Add 'faker' gem to development

e9a5789

Refactor: conditional on comments at 'posts' partial

7f0c914

Feat: Add button partial to 'user#show' page

966aab3

Refactor: 'PostsController#index' to Filter Posts by User

2353699

Add 'button_link' shared partial

667988e

Feat: update 'posts#index' view

46faccc

- Render 'user_card' partial. - Render 'posts' partial. - Render 'button_link' partial.

Refactor: change 'truncate_n' partial local value at 'posts#index' view

b435738

Feat: update 'PostsController#show' to Filter single Post by User

3788af3

Feat: Update 'posts' partial to handle single post and comments

56372c5

Feat: update 'posts#show' view

fc41ae3

- Render 'posts' partial. - Wrap 'posts' partial in 'main'.

Docs: Update 'README.md' check complete another future-feature

81534de

ITurres added documentation Improvements or additions to documentation enhancement New feature or request UI Views UI labels Dec 7, 2023

ITurres self-assigned this Dec 7, 2023

ITurres added 2 commits December 7, 2023 00:09

Docs: Update 'README.md' tech-stack section

d8e3719

Docs: Update 'README.md' by adding key-features section

5d42e21

Olamarx suggested changes Dec 7, 2023

View reviewed changes

ITurres requested a review from Olamarx December 7, 2023 04:02

MahmoudBakr23 approved these changes Dec 7, 2023

View reviewed changes

ITurres merged commit 4fe3caf into development Dec 7, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Milestone 6: views #6

Milestone 6: views #6

ITurres commented Dec 7, 2023

Olamarx left a comment

Olamarx Dec 7, 2023 •

edited by ITurres

Loading

ITurres Dec 7, 2023

Olamarx Dec 7, 2023

ITurres Dec 7, 2023 •

edited

Loading

ITurres Dec 7, 2023 •

edited

Loading

ITurres Dec 7, 2023

MahmoudBakr23 left a comment

ITurres commented Dec 7, 2023

Milestone 6: views #6

Milestone 6: views #6

Conversation

ITurres commented Dec 7, 2023

Pull Request Summary for Milestone 6 Completion

Added:

/app/views/posts/_posts.html.erb

/app/views/shared/_button_link.html.erb

/app/views/shared/_user_card.html.erb

Modified:

/README.md

/Gemfile and /Gemfile.lock

/app/controllers/posts_controller.rb

/app/controllers/users_controller.rb

/app/views/layouts/application.html.erb

/app/views/posts/index.html.erb

/app/views/posts/show.html.erb

/app/views/users/index.html.erb

/app/views/users/show.html.erb

Thank you for reviewing this PR. Feel free to reach out on Slack as Arturo (Arthur) Emanuel Guerra Iturres for any queries or further assistance. 🌟

Olamarx left a comment

Choose a reason for hiding this comment

Highlights

Required Changes ♻️

Optional suggestions

Olamarx Dec 7, 2023 • edited by ITurres Loading

Choose a reason for hiding this comment

ITurres Dec 7, 2023

Choose a reason for hiding this comment

Olamarx Dec 7, 2023

Choose a reason for hiding this comment

ITurres Dec 7, 2023 • edited Loading

Choose a reason for hiding this comment

ITurres Dec 7, 2023 • edited Loading

Choose a reason for hiding this comment

ITurres Dec 7, 2023

Choose a reason for hiding this comment

MahmoudBakr23 left a comment

Choose a reason for hiding this comment

ITurres commented Dec 7, 2023

`/app/views/posts/_posts.html.erb`

`/app/views/shared/_button_link.html.erb`

`/app/views/shared/_user_card.html.erb`

`/README.md`

`/Gemfile` and `/Gemfile.lock`

`/app/controllers/posts_controller.rb`

`/app/controllers/users_controller.rb`

`/app/views/layouts/application.html.erb`

`/app/views/posts/index.html.erb`

`/app/views/posts/show.html.erb`

`/app/views/users/index.html.erb`

`/app/views/users/show.html.erb`

Olamarx Dec 7, 2023 •

edited by ITurres

Loading

ITurres Dec 7, 2023 •

edited

Loading

ITurres Dec 7, 2023 •

edited

Loading