Milestone 8: views integration specs and fix n+1 problem on 'post#index' action

[ITurres]

Pull Request Summary for Milestone 8 Completion

• All requirements completed.

---

Added:

/spec/views/post_index_spec.rb

• @ITurres: Integration tests for the Post index view were added according to the requirements of the project

/spec/views/post_show_spec.rb

• @ITurres: Integration tests for the Post show view were added according to the requirements of the project.

/spec/views/user_index_spec.rb

• @demesameneshoa: Integration tests for the User index view were added according to the requirements of the project.

/spec/views/user_show_spec.rb

• @demesameneshoa: Integration tests for the User show view were added according to the requirements of the project.

---

Modified:

/README.md

• Marked the Integration specs for Views and fixing n+1 problems task as completed.
• Added @demesameneshoa as a contributor.

/app/models/user.rb

• @ITurres && @demesameneshoa: The includes method was added to the User model to avoid n+1 queries at the most_recent_posts method.

📸 Screenshots of n+1 queries before and after the changes:

Before:

After:

/app/views/posts/_posts.html.erb

• @ITurres: I have given a dynamic id for each post link.
  This way, we can test specific posts when we run the integration tests.

/app/views/shared/_user_card.html.erb

• @ITurres: I have remove the capitalize method from the user.name attribute.
  Since before it was downcasing the rest of the name. For example, Arthur Emanuel was being displayed as Arthur emanuel. Making the integration tests fail, because the user.name attribute was not matching the user.name attribute from the Post model.

/db/seeds.rb

• @ITurres: Now the sample data will contain a randomly generated avatar (photo) for each user.
• The https://robohash.org/accusantiumeaquea.png?size=200x200&set=set[NUMBER] url was used to generate the random avatars, with the help of the rand method with a range of 1 to 5.

/spec/examples.txt

• @ITurres && @demesameneshoa: New passed specs entries were added to the file.

---

Thank you for reviewing this PR. Feel free to reach out on Slack as Arturo (Arthur) Emanuel Guerra Iturres for any queries or further assistance. 🌟

[brainconnect93]

Status: Approved ✔️

Hi @ITurres & @demesameneshoa, 👋 👋

Your project is complete! Great job for following the project requirement🥇. There is nothing else to say other than... it's time to merge it 🍾🚢 . Congratulations! 🎉💯🌟

Good Points 👍

• Descriptive Pull Request title & summary. ✔️
• integration specs for views and fix n+1 problems ✔️
• Good use of Git flow ✔️

Optional changes

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers..Happy coding!..and keep soaring higher! 💻 🍷 🚀

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @brainconnect93 in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have 2 more limited reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.

[ITurres]

Hi @brainconnect93 Afolabi!

Thank you so much for having reviewed our PR 😃 🥂 and for contacting me over Zoom to check tests and snapshots. Wish you a great week and happy programming!