Fix redirection loop #5143
Merged
Fix redirection loop #5143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
added
bug
nilmerg
force-pushed
the
fix/redirection-loop-5133
branch
from
220ead4 to
81a2c75
Compare
A redirect caused by a form submit is **never** an automatic submit. Unless I'm missing something here. There is one way this may be true, as ipl forms without a submit button are indeed successful due to a autosubmit element, but they don't redirect by default. So if the controller redirects in such a case, the form should have a submit button, I guess.. Anyway, this is necessary due to the previous commit as this may otherwise cause form submits, that re-render layout during a redirect, are considered being auto submitted. (Such as the login form)
In case of a `__SELF__` redirect, the client should still have the parameter in the location and its preserved this way then.
nilmerg
force-pushed
the
fix/redirection-loop-5133
branch
from
81a2c75 to
a2c143d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5133