Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Css: Do not allow :hover to affect the .active list elements #5240

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Css: Do not allow :hover to affect the .active list elements #5240

merged 1 commit into from
Aug 7, 2024

Conversation

sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented Jul 31, 2024 •
edited
Loading

The .active state should not be overwritten by :hover.

@sukhwinder33445 sukhwinder33445 added the area/ui Affects the user interface label Jul 31, 2024
@sukhwinder33445 sukhwinder33445 self-assigned this Jul 31, 2024
@cla-bot cla-bot bot added the cla/signed label Jul 31, 2024
@nilmerg
Copy link
Member

nilmerg commented Jul 31, 2024

Why?

@sukhwinder33445
Copy link
Contributor Author

If you click on a list-item but do not move the cursor away, the active state is not visible. Icingadb-web shows it.

@nilmerg nilmerg merged commit 41a92e9 into main Aug 7, 2024
22 checks passed
@nilmerg nilmerg deleted the fix/dont-overwrite-active-state-with-hover branch August 7, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

Assignees

@sukhwinder33445 sukhwinder33445

Labels
area/ui Affects the user interface cla/signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sukhwinder33445 @nilmerg