Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planetary computer precipitation #339

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

barneydobson
Copy link
Collaborator

@barneydobson barneydobson commented Nov 6, 2024

Description

Update to use planetary computer

Fixes #20

Related to #55

Discussion

This works, but there is a bit of an issue in that I think ERA5 is actually 3 hour rolling average at an hourly timestep. I mean I guess it is better than nothing for global coverage... but it's probably not ideal.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 87.27%. Comparing base (ffb465a) to head (b981943).

Files with missing lines Patch % Lines
src/swmmanywhere/prepare_data.py 6.66% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   87.54%   87.27%   -0.28%     
==========================================
  Files          22       22              
  Lines        2224     2231       +7     
  Branches      282      283       +1     
==========================================
  Hits         1947     1947              
- Misses        198      205       +7     
  Partials       79       79              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@barneydobson barneydobson marked this pull request as draft November 7, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precipitation downloader needs to remove request from queue if interrupted
2 participants