Pre-merge (Coffee break)

fix: OR-2035 recursively apply validation rules for requests and invalidate html fields #1590

Triggered via pull request January 11, 2024 10:41

QuintenGreenstack

synchronize #595

OR-2035

Status Failure

Total duration 4m 29s

Artifacts 1

pre-merge-tests.yml

on: pull_request

Matrix: Run Tests

analyze-code

2m 32s

Notify slack

Annotations

1 error and 91 warnings

Run Tests (test/AssociationRegistry.Test.Admin.Api)

Process completed with exit code 1.

analyze-code

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-java@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

analyze-code: src/AssociationRegistry/Vereniging/ContactGegevens/Contactgegeven.cs#L14

Non-nullable property 'Bron' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

analyze-code: src/AssociationRegistry/Vereniging/VerenigingMetRechtspersoonlijkheid.cs#L11

Non-nullable field '_allowedTypes' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.

analyze-code: src/AssociationRegistry/Vereniging/ContactGegevens/Exceptions/ActieIsNietToegestaanVoorContactgegevenBron.cs#L7

Make this class name end with 'Exception'.

analyze-code: src/AssociationRegistry/Vereniging/ContactGegevens/Exceptions/ContactgegevenIsDuplicaat.cs#L7

Make this class name end with 'Exception'.

analyze-code: src/AssociationRegistry/Vereniging/ContactGegevens/Emails/Exceptions/EmailHeeftEenOngeldigFormaat.cs#L7

Make this class name end with 'Exception'.

analyze-code: src/AssociationRegistry/Vereniging/ContactGegevens/Exceptions/ContactgegevenIsNietGekend.cs#L7

Make this class name end with 'Exception'.

analyze-code: src/AssociationRegistry/Vereniging/ContactGegevens/Exceptions/ContactgegevenUitKboKanNietGewijzigdWorden.cs#L7

Make this class name end with 'Exception'.

analyze-code: src/AssociationRegistry/Vereniging/ContactGegevens/Exceptions/ContactgegevenUitKboKanNietVerwijderdWorden.cs#L7

Make this class name end with 'Exception'.

analyze-code: src/AssociationRegistry/Vereniging/ContactGegevens/Exceptions/ContactTypeIsOngeldig.cs#L7

Make this class name end with 'Exception'.

analyze-code: src/AssociationRegistry/Vereniging/ContactGegevens/Exceptions/MeerderePrimaireContactgegevensZijnNietToegestaan.cs#L7

Make this class name end with 'Exception'.

Run Tests (test/AssociationRegistry.Test)

Non-nullable property 'Bron' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

Run Tests (test/AssociationRegistry.Test)

Non-nullable field '_allowedTypes' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.

Run Tests (test/AssociationRegistry.Test)

Possible null reference argument for parameter 'parentId' in 'Activity Activity.SetParentId(string parentId)'.

Run Tests (test/AssociationRegistry.Test)

Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.

Run Tests (test/AssociationRegistry.Test)

Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.

Run Tests (test/AssociationRegistry.Test)

Possible null reference argument for parameter 'id' in 'AtomFeedConfiguration.AtomFeedConfiguration(string id, string title, string subtitle, string generatorTitle, string generatorUri, string generatorVersion, string rights, DateTimeOffset updated, SyndicationPerson author, SyndicationLink selfUri, List<SyndicationLink> alternateUris, List<SyndicationLink> relatedUris)'.

Run Tests (test/AssociationRegistry.Test)

Possible null reference argument for parameter 'title' in 'AtomFeedConfiguration.AtomFeedConfiguration(string id, string title, string subtitle, string generatorTitle, string generatorUri, string generatorVersion, string rights, DateTimeOffset updated, SyndicationPerson author, SyndicationLink selfUri, List<SyndicationLink> alternateUris, List<SyndicationLink> relatedUris)'.

Run Tests (test/AssociationRegistry.Test)

Possible null reference argument for parameter 'subtitle' in 'AtomFeedConfiguration.AtomFeedConfiguration(string id, string title, string subtitle, string generatorTitle, string generatorUri, string generatorVersion, string rights, DateTimeOffset updated, SyndicationPerson author, SyndicationLink selfUri, List<SyndicationLink> alternateUris, List<SyndicationLink> relatedUris)'.

Run Tests (test/AssociationRegistry.Test)

Possible null reference argument for parameter 'generatorTitle' in 'AtomFeedConfiguration.AtomFeedConfiguration(string id, string title, string subtitle, string generatorTitle, string generatorUri, string generatorVersion, string rights, DateTimeOffset updated, SyndicationPerson author, SyndicationLink selfUri, List<SyndicationLink> alternateUris, List<SyndicationLink> relatedUris)'.

Run Tests (test/AssociationRegistry.Test)

Possible null reference argument for parameter 'generatorUri' in 'AtomFeedConfiguration.AtomFeedConfiguration(string id, string title, string subtitle, string generatorTitle, string generatorUri, string generatorVersion, string rights, DateTimeOffset updated, SyndicationPerson author, SyndicationLink selfUri, List<SyndicationLink> alternateUris, List<SyndicationLink> relatedUris)'.

Run Tests (test/AssociationRegistry.Test): src/AssociationRegistry.OpenTelemetry/Extensions/ServiceCollectionExtensions.cs#L124

Possible null reference argument for parameter 'parentId' in 'Activity Activity.SetParentId(string parentId)'.

Run Tests (test/AssociationRegistry.Test): src/AssociationRegistry/Vereniging/ContactGegevens/Contactgegeven.cs#L14

Non-nullable property 'Bron' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

Run Tests (test/AssociationRegistry.Test): src/AssociationRegistry/Vereniging/VerenigingMetRechtspersoonlijkheid.cs#L11

Non-nullable field '_allowedTypes' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.

Run Tests (test/AssociationRegistry.Test): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L26

Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.

Run Tests (test/AssociationRegistry.Test): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L33

Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.

Run Tests (test/AssociationRegistry.Test): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L17

Run Tests (test/AssociationRegistry.Test): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L18

Run Tests (test/AssociationRegistry.Test): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L19

Run Tests (test/AssociationRegistry.Test): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L20

Run Tests (test/AssociationRegistry.Test): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L21

Run Tests (test/AssociationRegistry.Test.Acm.Api)

Non-nullable field '_allowedTypes' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.

Run Tests (test/AssociationRegistry.Test.Acm.Api)

Non-nullable property 'Bron' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

Run Tests (test/AssociationRegistry.Test.Acm.Api)

Possible null reference argument for parameter 'parentId' in 'Activity Activity.SetParentId(string parentId)'.

Run Tests (test/AssociationRegistry.Test.Acm.Api)

Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.

Run Tests (test/AssociationRegistry.Test.Acm.Api)

Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.

Run Tests (test/AssociationRegistry.Test.Acm.Api)

Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry/Vereniging/ContactGegevens/Contactgegeven.cs#L14

Non-nullable property 'Bron' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry/Vereniging/VerenigingMetRechtspersoonlijkheid.cs#L11

Non-nullable field '_allowedTypes' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.

Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry.OpenTelemetry/Extensions/ServiceCollectionExtensions.cs#L124

Possible null reference argument for parameter 'parentId' in 'Activity Activity.SetParentId(string parentId)'.

Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry.Public.ProjectionHost/Infrastructure/Metrics/ProjectionStateListener.cs#L51

Dereference of a possibly null reference.

Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry.Public.ProjectionHost/Infrastructure/Metrics/ProjectionStateListener.cs#L53

Dereference of a possibly null reference.

Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry.Public.ProjectionHost/Infrastructure/Program/WebApplicationBuilder/ConfigurationExtensions.cs#L12

Possible null reference argument for parameter 'postgreSqlOptions' in 'void ConfigHelpers.ThrowIfInvalidPostgreSqlOptions(PostgreSqlOptionsSection postgreSqlOptions)'.

Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry.Public.ProjectionHost/Infrastructure/Program/WebApplicationBuilder/ConfigurationExtensions.cs#L21

Possible null reference argument for parameter 'elasticSearchOptions' in 'void ConfigHelpers.ThrowIfInvalidElasticOptions(ElasticSearchOptionsSection elasticSearchOptions)'.

Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry.Public.ProjectionHost/Infrastructure/Program/WebApplicationBuilder/ConfigureMartenExtensions.cs#L68

Possible null reference argument for parameter 'postgreSqlOptions' in 'string GetPostgresConnectionString(PostgreSqlOptionsSection postgreSqlOptions)'.

Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry.Public.ProjectionHost/Program.cs#L107

Dereference of a possibly null reference.

Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L26

Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.

Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry.OpenTelemetry/Extensions/ServiceCollectionExtensions.cs#L124

Possible null reference argument for parameter 'parentId' in 'Activity Activity.SetParentId(string parentId)'.

Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry/Vereniging/ContactGegevens/Contactgegeven.cs#L14

Non-nullable property 'Bron' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry/Vereniging/VerenigingMetRechtspersoonlijkheid.cs#L11

Non-nullable field '_allowedTypes' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.

Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry.Public.Api/Infrastructure/Extensions/ConfigurationExtensions.cs#L15

Possible null reference argument for parameter 'postgreSqlOptions' in 'void ConfigurationExtensions.ThrowIfInvalid(PostgreSqlOptionsSection postgreSqlOptions)'.

Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry.Public.Api/Infrastructure/Extensions/ConfigurationExtensions.cs#L38

Possible null reference argument for parameter 'elasticSearchOptions' in 'void ConfigurationExtensions.ThrowIfInvalid(ElasticSearchOptionsSection elasticSearchOptions)'.

Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry.Public.Api/Infrastructure/Extensions/ConfigurationExtensions.cs#L57

Dereference of a possibly null reference.

Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry.Public.Api/Verenigingen/Search/SearchVerenigingenExtensions.cs#L61

Possible null reference return.

Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry.Public.Api/Program.cs#L245

The type 'AssociationRegistry.Public.Api.Infrastructure.ConfigurationBindings.AppSettings?' cannot be used as type parameter 'TService' in the generic type or method 'ServiceCollectionServiceExtensions.AddSingleton<TService>(IServiceCollection, TService)'. Nullability of type argument 'AssociationRegistry.Public.Api.Infrastructure.ConfigurationBindings.AppSettings?' doesn't match 'class' constraint.

Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry.Public.Api/Program.cs#L396

Possible null reference argument for parameter 'appSettings' in 'IServiceCollection SwaggerExtensions.AddPublicApiSwagger(IServiceCollection services, AppSettings appSettings)'.

Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry.Public.Api/Verenigingen/Search/SearchVerenigingenController.cs#L136

Parameter 'logger' has no matching param tag in the XML comment for 'SearchVerenigingenController.Zoeken(string?, string?, string?, PaginationQueryParams, IValidator<PaginationQueryParams>, ILogger<SearchVerenigingenController>, CancellationToken)' (but other parameters do)

Run Tests (test/AssociationRegistry.Test.Public.Api)

Possible null reference argument for parameter 'parentId' in 'Activity Activity.SetParentId(string parentId)'.

Run Tests (test/AssociationRegistry.Test.Public.Api)

Non-nullable property 'Bron' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

Run Tests (test/AssociationRegistry.Test.Public.Api)

Non-nullable field '_allowedTypes' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.

Run Tests (test/AssociationRegistry.Test.Public.Api)

Dereference of a possibly null reference.

Run Tests (test/AssociationRegistry.Test.Public.Api)

Dereference of a possibly null reference.

Run Tests (test/AssociationRegistry.Test.Public.Api)

Dereference of a possibly null reference.

Run Tests (test/AssociationRegistry.Test.Public.Api)

Possible null reference argument for parameter 'postgreSqlOptions' in 'void ConfigHelpers.ThrowIfInvalidPostgreSqlOptions(PostgreSqlOptionsSection postgreSqlOptions)'.

Run Tests (test/AssociationRegistry.Test.Public.Api)

Possible null reference argument for parameter 'elasticSearchOptions' in 'void ConfigHelpers.ThrowIfInvalidElasticOptions(ElasticSearchOptionsSection elasticSearchOptions)'.

Run Tests (test/AssociationRegistry.Test.Public.Api)

Possible null reference argument for parameter 'postgreSqlOptions' in 'string GetPostgresConnectionString(PostgreSqlOptionsSection postgreSqlOptions)'.

Run Tests (test/AssociationRegistry.Test.Public.Api)

Possible null reference return.

Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry.OpenTelemetry/Extensions/ServiceCollectionExtensions.cs#L124

Possible null reference argument for parameter 'parentId' in 'Activity Activity.SetParentId(string parentId)'.

Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry/Vereniging/ContactGegevens/Contactgegeven.cs#L14

Non-nullable property 'Bron' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry/Vereniging/VerenigingMetRechtspersoonlijkheid.cs#L11

Non-nullable field '_allowedTypes' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.

Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry.Public.ProjectionHost/Infrastructure/Metrics/ProjectionStateListener.cs#L51

Dereference of a possibly null reference.

Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry.Public.ProjectionHost/Infrastructure/Metrics/ProjectionStateListener.cs#L53

Dereference of a possibly null reference.

Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry.Public.ProjectionHost/Infrastructure/Program/WebApplicationBuilder/ConfigurationExtensions.cs#L12

Possible null reference argument for parameter 'postgreSqlOptions' in 'void ConfigHelpers.ThrowIfInvalidPostgreSqlOptions(PostgreSqlOptionsSection postgreSqlOptions)'.

Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry.Public.ProjectionHost/Infrastructure/Program/WebApplicationBuilder/ConfigurationExtensions.cs#L21

Possible null reference argument for parameter 'elasticSearchOptions' in 'void ConfigHelpers.ThrowIfInvalidElasticOptions(ElasticSearchOptionsSection elasticSearchOptions)'.

Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry.Public.ProjectionHost/Infrastructure/Program/WebApplicationBuilder/ConfigureMartenExtensions.cs#L68

Possible null reference argument for parameter 'postgreSqlOptions' in 'string GetPostgresConnectionString(PostgreSqlOptionsSection postgreSqlOptions)'.

Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry.Public.ProjectionHost/Program.cs#L107

Dereference of a possibly null reference.

Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry.Public.Api/Infrastructure/Extensions/ConfigurationExtensions.cs#L15

Possible null reference argument for parameter 'postgreSqlOptions' in 'void ConfigurationExtensions.ThrowIfInvalid(PostgreSqlOptionsSection postgreSqlOptions)'.

Run Tests (test/AssociationRegistry.Test.Admin.Api)

Possible null reference argument for parameter 'parentId' in 'Activity Activity.SetParentId(string parentId)'.

Run Tests (test/AssociationRegistry.Test.Admin.Api)

Non-nullable property 'Bron' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

Run Tests (test/AssociationRegistry.Test.Admin.Api)

Non-nullable field '_allowedTypes' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.

Run Tests (test/AssociationRegistry.Test.Admin.Api)

Dereference of a possibly null reference.

Run Tests (test/AssociationRegistry.Test.Admin.Api)

Dereference of a possibly null reference.

Run Tests (test/AssociationRegistry.Test.Admin.Api)

Possible null reference argument for parameter 'postgreSqlOptions' in 'void ConfigHelpers.ThrowIfInvalidPostgreSqlOptions(PostgreSqlOptionsSection postgreSqlOptions)'.

Run Tests (test/AssociationRegistry.Test.Admin.Api)

Possible null reference argument for parameter 'elasticSearchOptions' in 'void ConfigHelpers.ThrowIfInvalidElasticOptions(ElasticSearchOptionsSection elasticSearchOptions)'.

Run Tests (test/AssociationRegistry.Test.Admin.Api)

Dereference of a possibly null reference.

Run Tests (test/AssociationRegistry.Test.Admin.Api)

Possible null reference argument for parameter 'postgreSqlOptions' in 'string GetPostgresConnectionString(PostgreSqlOptionsSection postgreSqlOptions)'.

Run Tests (test/AssociationRegistry.Test.Admin.Api)

Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.

Artifacts

Produced during runtime

Name	Size
test-report Expired	1.1 MB

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: OR-2035 recursively apply validation rules for requests and invalidate html fields #1590

Summary