Skip to content

fix: OR-2058 reverse condition on duplicate detection for IsDeleted #1600

fix: OR-2058 reverse condition on duplicate detection for IsDeleted

fix: OR-2058 reverse condition on duplicate detection for IsDeleted #1600

Triggered via pull request January 18, 2024 10:02
Status Success
Total duration 6m 32s
Artifacts 1

pre-merge-tests.yml

on: pull_request
Matrix: Run Tests
Notify slack
4s
Notify slack
Fit to window
Zoom out
Zoom in

Annotations

91 warnings
analyze-code
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-java@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
analyze-code: src/AssociationRegistry/Vereniging/ContactGegevens/Contactgegeven.cs#L14
Non-nullable property 'Bron' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
analyze-code: src/AssociationRegistry/Vereniging/VerenigingMetRechtspersoonlijkheid.cs#L11
Non-nullable field '_allowedTypes' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
analyze-code: src/AssociationRegistry/Vereniging/Exceptions/VerenigingWerdVerwijderd.cs#L16
Non-nullable property 'Vcode' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
analyze-code: src/AssociationRegistry.OpenTelemetry/Extensions/ServiceCollectionExtensions.cs#L124
Possible null reference argument for parameter 'parentId' in 'Activity Activity.SetParentId(string parentId)'.
analyze-code: src/AssociationRegistry.Public.ProjectionHost/Infrastructure/Program/WebApplicationBuilder/ConfigurationExtensions.cs#L12
Possible null reference argument for parameter 'postgreSqlOptions' in 'void ConfigHelpers.ThrowIfInvalidPostgreSqlOptions(PostgreSqlOptionsSection postgreSqlOptions)'.
analyze-code: src/AssociationRegistry.Public.ProjectionHost/Infrastructure/Program/WebApplicationBuilder/ConfigurationExtensions.cs#L22
Possible null reference argument for parameter 'elasticSearchOptions' in 'void ConfigHelpers.ThrowIfInvalidElasticOptions(ElasticSearchOptionsSection elasticSearchOptions)'.
analyze-code: src/AssociationRegistry.Public.ProjectionHost/Program.cs#L107
Dereference of a possibly null reference.
analyze-code: src/AssociationRegistry.Public.ProjectionHost/Projections/Detail/PubliekVerenigingDetailProjection.cs#L132
Possible null reference argument for parameter 'id' in 'void IDocumentOperations.Delete<PubliekVerenigingDetailDocument>(string id)'.
Run Tests (test/AssociationRegistry.Test.Acm.Api)
Possible null reference argument for parameter 'parentId' in 'Activity Activity.SetParentId(string parentId)'.
Run Tests (test/AssociationRegistry.Test.Acm.Api)
Non-nullable field '_allowedTypes' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
Run Tests (test/AssociationRegistry.Test.Acm.Api)
Non-nullable property 'Vcode' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Run Tests (test/AssociationRegistry.Test.Acm.Api)
Non-nullable property 'Bron' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Run Tests (test/AssociationRegistry.Test.Acm.Api)
Possible null reference argument for parameter 'id' in 'void IDocumentOperations.Delete<PubliekVerenigingDetailDocument>(string id)'.
Run Tests (test/AssociationRegistry.Test.Acm.Api)
Dereference of a possibly null reference.
Run Tests (test/AssociationRegistry.Test.Acm.Api)
Dereference of a possibly null reference.
Run Tests (test/AssociationRegistry.Test.Acm.Api)
Dereference of a possibly null reference.
Run Tests (test/AssociationRegistry.Test.Acm.Api)
Possible null reference argument for parameter 'postgreSqlOptions' in 'string GetPostgresConnectionString(PostgreSqlOptionsSection postgreSqlOptions)'.
Run Tests (test/AssociationRegistry.Test.Acm.Api)
Possible null reference argument for parameter 'postgreSqlOptions' in 'void ConfigHelpers.ThrowIfInvalidPostgreSqlOptions(PostgreSqlOptionsSection postgreSqlOptions)'.
Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry.OpenTelemetry/Extensions/ServiceCollectionExtensions.cs#L124
Possible null reference argument for parameter 'parentId' in 'Activity Activity.SetParentId(string parentId)'.
Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry/Vereniging/ContactGegevens/Contactgegeven.cs#L14
Non-nullable property 'Bron' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry/Vereniging/Exceptions/VerenigingWerdVerwijderd.cs#L16
Non-nullable property 'Vcode' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry/Vereniging/VerenigingMetRechtspersoonlijkheid.cs#L11
Non-nullable field '_allowedTypes' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L26
Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L33
Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L17
Possible null reference argument for parameter 'id' in 'AtomFeedConfiguration.AtomFeedConfiguration(string id, string title, string subtitle, string generatorTitle, string generatorUri, string generatorVersion, string rights, DateTimeOffset updated, SyndicationPerson author, SyndicationLink selfUri, List<SyndicationLink> alternateUris, List<SyndicationLink> relatedUris)'.
Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L18
Possible null reference argument for parameter 'title' in 'AtomFeedConfiguration.AtomFeedConfiguration(string id, string title, string subtitle, string generatorTitle, string generatorUri, string generatorVersion, string rights, DateTimeOffset updated, SyndicationPerson author, SyndicationLink selfUri, List<SyndicationLink> alternateUris, List<SyndicationLink> relatedUris)'.
Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L19
Possible null reference argument for parameter 'subtitle' in 'AtomFeedConfiguration.AtomFeedConfiguration(string id, string title, string subtitle, string generatorTitle, string generatorUri, string generatorVersion, string rights, DateTimeOffset updated, SyndicationPerson author, SyndicationLink selfUri, List<SyndicationLink> alternateUris, List<SyndicationLink> relatedUris)'.
Run Tests (test/AssociationRegistry.Test.Acm.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L20
Possible null reference argument for parameter 'generatorTitle' in 'AtomFeedConfiguration.AtomFeedConfiguration(string id, string title, string subtitle, string generatorTitle, string generatorUri, string generatorVersion, string rights, DateTimeOffset updated, SyndicationPerson author, SyndicationLink selfUri, List<SyndicationLink> alternateUris, List<SyndicationLink> relatedUris)'.
Run Tests (test/AssociationRegistry.Test)
Possible null reference argument for parameter 'parentId' in 'Activity Activity.SetParentId(string parentId)'.
Run Tests (test/AssociationRegistry.Test)
Non-nullable field '_allowedTypes' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
Run Tests (test/AssociationRegistry.Test)
Non-nullable property 'Bron' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Run Tests (test/AssociationRegistry.Test)
Non-nullable property 'Vcode' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Run Tests (test/AssociationRegistry.Test)
Dereference of a possibly null reference.
Run Tests (test/AssociationRegistry.Test)
Dereference of a possibly null reference.
Run Tests (test/AssociationRegistry.Test)
Possible null reference argument for parameter 'postgreSqlOptions' in 'string GetPostgresConnectionString(PostgreSqlOptionsSection postgreSqlOptions)'.
Run Tests (test/AssociationRegistry.Test)
Possible null reference argument for parameter 'postgreSqlOptions' in 'void ConfigHelpers.ThrowIfInvalidPostgreSqlOptions(PostgreSqlOptionsSection postgreSqlOptions)'.
Run Tests (test/AssociationRegistry.Test)
Possible null reference argument for parameter 'elasticSearchOptions' in 'void ConfigHelpers.ThrowIfInvalidElasticOptions(ElasticSearchOptionsSection elasticSearchOptions)'.
Run Tests (test/AssociationRegistry.Test)
Dereference of a possibly null reference.
Run Tests (test/AssociationRegistry.Test): src/AssociationRegistry.OpenTelemetry/Extensions/ServiceCollectionExtensions.cs#L124
Possible null reference argument for parameter 'parentId' in 'Activity Activity.SetParentId(string parentId)'.
Run Tests (test/AssociationRegistry.Test): src/AssociationRegistry/Vereniging/ContactGegevens/Contactgegeven.cs#L14
Non-nullable property 'Bron' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Run Tests (test/AssociationRegistry.Test): src/AssociationRegistry/Vereniging/VerenigingMetRechtspersoonlijkheid.cs#L11
Non-nullable field '_allowedTypes' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
Run Tests (test/AssociationRegistry.Test): src/AssociationRegistry/Vereniging/Exceptions/VerenigingWerdVerwijderd.cs#L16
Non-nullable property 'Vcode' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Run Tests (test/AssociationRegistry.Test): src/AssociationRegistry.Public.Api/Infrastructure/Extensions/ConfigurationExtensions.cs#L16
Possible null reference argument for parameter 'postgreSqlOptions' in 'void ConfigurationExtensions.ThrowIfInvalid(PostgreSqlOptionsSection postgreSqlOptions)'.
Run Tests (test/AssociationRegistry.Test): src/AssociationRegistry.Public.Api/Infrastructure/Extensions/ConfigurationExtensions.cs#L44
Possible null reference argument for parameter 'elasticSearchOptions' in 'void ConfigurationExtensions.ThrowIfInvalid(ElasticSearchOptionsSection elasticSearchOptions)'.
Run Tests (test/AssociationRegistry.Test): src/AssociationRegistry.Public.Api/Program.cs#L246
The type 'AssociationRegistry.Public.Api.Infrastructure.ConfigurationBindings.AppSettings?' cannot be used as type parameter 'TService' in the generic type or method 'ServiceCollectionServiceExtensions.AddSingleton<TService>(IServiceCollection, TService)'. Nullability of type argument 'AssociationRegistry.Public.Api.Infrastructure.ConfigurationBindings.AppSettings?' doesn't match 'class' constraint.
Run Tests (test/AssociationRegistry.Test): src/AssociationRegistry.Public.Api/Program.cs#L398
Possible null reference argument for parameter 'appSettings' in 'IServiceCollection SwaggerExtensions.AddPublicApiSwagger(IServiceCollection services, AppSettings appSettings)'.
Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry/Vereniging/ContactGegevens/Contactgegeven.cs#L14
Non-nullable property 'Bron' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry/Vereniging/Exceptions/VerenigingWerdVerwijderd.cs#L16
Non-nullable property 'Vcode' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry/Vereniging/VerenigingMetRechtspersoonlijkheid.cs#L11
Non-nullable field '_allowedTypes' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry.OpenTelemetry/Extensions/ServiceCollectionExtensions.cs#L124
Possible null reference argument for parameter 'parentId' in 'Activity Activity.SetParentId(string parentId)'.
Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L26
Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L33
Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L17
Possible null reference argument for parameter 'id' in 'AtomFeedConfiguration.AtomFeedConfiguration(string id, string title, string subtitle, string generatorTitle, string generatorUri, string generatorVersion, string rights, DateTimeOffset updated, SyndicationPerson author, SyndicationLink selfUri, List<SyndicationLink> alternateUris, List<SyndicationLink> relatedUris)'.
Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L18
Possible null reference argument for parameter 'title' in 'AtomFeedConfiguration.AtomFeedConfiguration(string id, string title, string subtitle, string generatorTitle, string generatorUri, string generatorVersion, string rights, DateTimeOffset updated, SyndicationPerson author, SyndicationLink selfUri, List<SyndicationLink> alternateUris, List<SyndicationLink> relatedUris)'.
Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L19
Possible null reference argument for parameter 'subtitle' in 'AtomFeedConfiguration.AtomFeedConfiguration(string id, string title, string subtitle, string generatorTitle, string generatorUri, string generatorVersion, string rights, DateTimeOffset updated, SyndicationPerson author, SyndicationLink selfUri, List<SyndicationLink> alternateUris, List<SyndicationLink> relatedUris)'.
Run Tests (test/AssociationRegistry.Test.Admin.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L20
Possible null reference argument for parameter 'generatorTitle' in 'AtomFeedConfiguration.AtomFeedConfiguration(string id, string title, string subtitle, string generatorTitle, string generatorUri, string generatorVersion, string rights, DateTimeOffset updated, SyndicationPerson author, SyndicationLink selfUri, List<SyndicationLink> alternateUris, List<SyndicationLink> relatedUris)'.
Run Tests (test/AssociationRegistry.Test.Admin.Api)
Non-nullable property 'Bron' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Run Tests (test/AssociationRegistry.Test.Admin.Api)
Non-nullable property 'Vcode' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Run Tests (test/AssociationRegistry.Test.Admin.Api)
Non-nullable field '_allowedTypes' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
Run Tests (test/AssociationRegistry.Test.Admin.Api)
Possible null reference argument for parameter 'parentId' in 'Activity Activity.SetParentId(string parentId)'.
Run Tests (test/AssociationRegistry.Test.Admin.Api)
Possible null reference argument for parameter 'postgreSqlOptions' in 'void ConfigHelpers.ThrowIfInvalidPostgreSqlOptions(PostgreSqlOptionsSection postgreSqlOptions)'.
Run Tests (test/AssociationRegistry.Test.Admin.Api)
Possible null reference argument for parameter 'elasticSearchOptions' in 'void ConfigHelpers.ThrowIfInvalidElasticOptions(ElasticSearchOptionsSection elasticSearchOptions)'.
Run Tests (test/AssociationRegistry.Test.Admin.Api)
Dereference of a possibly null reference.
Run Tests (test/AssociationRegistry.Test.Admin.Api)
Dereference of a possibly null reference.
Run Tests (test/AssociationRegistry.Test.Admin.Api)
Possible null reference argument for parameter 'postgreSqlOptions' in 'string GetPostgresConnectionString(PostgreSqlOptionsSection postgreSqlOptions)'.
Run Tests (test/AssociationRegistry.Test.Admin.Api)
Possible null reference argument for parameter 'id' in 'void IDocumentOperations.Delete<PubliekVerenigingDetailDocument>(string id)'.
Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry.OpenTelemetry/Extensions/ServiceCollectionExtensions.cs#L124
Possible null reference argument for parameter 'parentId' in 'Activity Activity.SetParentId(string parentId)'.
Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry/Vereniging/ContactGegevens/Contactgegeven.cs#L14
Non-nullable property 'Bron' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry/Vereniging/Exceptions/VerenigingWerdVerwijderd.cs#L16
Non-nullable property 'Vcode' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry/Vereniging/VerenigingMetRechtspersoonlijkheid.cs#L11
Non-nullable field '_allowedTypes' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L26
Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L33
Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L17
Possible null reference argument for parameter 'id' in 'AtomFeedConfiguration.AtomFeedConfiguration(string id, string title, string subtitle, string generatorTitle, string generatorUri, string generatorVersion, string rights, DateTimeOffset updated, SyndicationPerson author, SyndicationLink selfUri, List<SyndicationLink> alternateUris, List<SyndicationLink> relatedUris)'.
Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L18
Possible null reference argument for parameter 'title' in 'AtomFeedConfiguration.AtomFeedConfiguration(string id, string title, string subtitle, string generatorTitle, string generatorUri, string generatorVersion, string rights, DateTimeOffset updated, SyndicationPerson author, SyndicationLink selfUri, List<SyndicationLink> alternateUris, List<SyndicationLink> relatedUris)'.
Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L19
Possible null reference argument for parameter 'subtitle' in 'AtomFeedConfiguration.AtomFeedConfiguration(string id, string title, string subtitle, string generatorTitle, string generatorUri, string generatorVersion, string rights, DateTimeOffset updated, SyndicationPerson author, SyndicationLink selfUri, List<SyndicationLink> alternateUris, List<SyndicationLink> relatedUris)'.
Run Tests (test/AssociationRegistry.Test.Public.Api): src/AssociationRegistry.Acm.Api/Infrastructure/Options/AtomFeedConfigurationBuilder.cs#L20
Possible null reference argument for parameter 'generatorTitle' in 'AtomFeedConfiguration.AtomFeedConfiguration(string id, string title, string subtitle, string generatorTitle, string generatorUri, string generatorVersion, string rights, DateTimeOffset updated, SyndicationPerson author, SyndicationLink selfUri, List<SyndicationLink> alternateUris, List<SyndicationLink> relatedUris)'.
Run Tests (test/AssociationRegistry.Test.Public.Api)
Possible null reference argument for parameter 'parentId' in 'Activity Activity.SetParentId(string parentId)'.
Run Tests (test/AssociationRegistry.Test.Public.Api)
Non-nullable field '_allowedTypes' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
Run Tests (test/AssociationRegistry.Test.Public.Api)
Non-nullable property 'Bron' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Run Tests (test/AssociationRegistry.Test.Public.Api)
Non-nullable property 'Vcode' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Run Tests (test/AssociationRegistry.Test.Public.Api)
Possible null reference argument for parameter 'id' in 'void IDocumentOperations.Delete<PubliekVerenigingDetailDocument>(string id)'.
Run Tests (test/AssociationRegistry.Test.Public.Api)
Dereference of a possibly null reference.
Run Tests (test/AssociationRegistry.Test.Public.Api)
Dereference of a possibly null reference.
Run Tests (test/AssociationRegistry.Test.Public.Api)
Dereference of a possibly null reference.
Run Tests (test/AssociationRegistry.Test.Public.Api)
Possible null reference argument for parameter 'postgreSqlOptions' in 'string GetPostgresConnectionString(PostgreSqlOptionsSection postgreSqlOptions)'.
Run Tests (test/AssociationRegistry.Test.Public.Api)
Possible null reference argument for parameter 'postgreSqlOptions' in 'void ConfigHelpers.ThrowIfInvalidPostgreSqlOptions(PostgreSqlOptionsSection postgreSqlOptions)'.

Artifacts

Produced during runtime
Name Size
test-report Expired
548 KB