fix: or-1217 change validation message for association deleted

src/AssociationRegistry.Admin.Api/ValidationMessages.resx

@@ -23,6 +23,9 @@
   <data name="Status404Detail" xml:space="preserve">
     <value>De gevraagde vereniging werd niet gevonden.</value>
   </data>
+  <data name="Status404Deleted" xml:space="preserve">
+    <value>Deze vereniging werd verwijderd.</value>
+  </data>
   <data name="Status412Detail" xml:space="preserve">
     <value>Het detail van de gevraagde vereniging heeft niet de verwachte sequentiewaarde.</value>
   </data>

src/AssociationRegistry.Admin.Api/Verenigingen/Detail/DetailVerenigingenController.cs

@@ -9,11 +9,13 @@ namespace AssociationRegistry.Admin.Api.Verenigingen.Detail;
 using Infrastructure.Swagger.Annotations;
 using Infrastructure.Swagger.Examples;
 using Marten;
+using Marten.Linq.SoftDeletes;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Mvc;
 using ResponseModels;
 using Schema.Detail;
 using Swashbuckle.AspNetCore.Filters;
+using System.Linq;
 using System.Threading.Tasks;
 using ProblemDetails = Be.Vlaanderen.Basisregisters.BasicApiProblem.ProblemDetails;
 
@@ -67,12 +69,16 @@ public async Task<IActionResult> Detail(
             throw new UnexpectedAggregateVersionException(ValidationMessages.Status412Detail);
 
         var maybeVereniging = await session.Query<BeheerVerenigingDetailDocument>()
+                                           .Where(x => x.MaybeDeleted())
                                            .WithVCode(vCode)
                                            .SingleOrDefaultAsync();
 
         if (maybeVereniging is not { } vereniging)
             return await Response.WriteNotFoundProblemDetailsAsync(problemDetailsHelper, ValidationMessages.Status404Detail);
 
+        if (maybeVereniging.Deleted)
+            return await Response.WriteNotFoundProblemDetailsAsync(problemDetailsHelper, ValidationMessages.Status404Deleted);
+
         Response.AddETagHeader(vereniging.Metadata.Version);
 
         return Ok(_mapper.Map(vereniging));

test/AssociationRegistry.Test.Admin.Api/When_Retrieving_Detail/Given_A_Vereniging_Has_Been_Removed.cs

@@ -37,6 +37,6 @@ public async Task Then_we_get_a_detail()
         var problemDetails = JsonConvert.DeserializeObject<ProblemDetails>(content);
 
         problemDetails.Detail.Should().NotBeEmpty();
-        problemDetails.Detail.Should().Be(ValidationMessages.Status404Detail);
+        problemDetails.Detail.Should().Be(ValidationMessages.Status404Deleted);
     }
 }