fix: OR-2058 reverse condition on duplicate detection for IsDeleted

Informatievlaanderen · Jan 18, 2024 · 987a201 · 987a201
1 parent 82528b5
commit 987a201
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/...ciationRegistry.Admin.Api/DuplicateDetection/SearchDuplicateVerenigingDetectionService.cs b/...ciationRegistry.Admin.Api/DuplicateDetection/SearchDuplicateVerenigingDetectionService.cs
@@ -36,9 +36,9 @@ await _client
                             q => q.Bool(
                                 b => b.Must(
                                            MatchOpNaam(naam),
-                                           IsNietGestopt,
-                                           IsNietVerwijderd
+                                           IsNietGestopt
                                        )
+                                      .MustNot(BeVerwijderd)
                                       .Filter(MatchOpPostcodeOfGemeente(gemeentes, postcodes)
                                        )
                             )
@@ -71,10 +71,13 @@ private static QueryContainer IsNietGestopt(QueryContainerDescriptor<DuplicateDe
                                                                  .Value(false));
     }
 
-    private static QueryContainer IsNietVerwijderd(QueryContainerDescriptor<DuplicateDetectionDocument> descriptor)
+    private static QueryContainer BeVerwijderd(QueryContainerDescriptor<DuplicateDetectionDocument> shouldDescriptor)
     {
-        return descriptor.Term(queryDescriptor => queryDescriptor.Field(document => document.IsVerwijderd)
-                                                                 .Value(false));
+        return shouldDescriptor
+           .Term(termDescriptor
+                     => termDescriptor
+                       .Field(document => document.IsVerwijderd)
+                       .Value(true));
     }
 
     private static Func<QueryContainerDescriptor<DuplicateDetectionDocument>, QueryContainer> MatchOpPostcode(string[] postcodes)