Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OR-1993 rename relatie.type to relatie.relatietype #561

Merged
merged 2 commits into from
Nov 28, 2023
Merged

feat: OR-1993 rename relatie.type to relatie.relatietype #561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fd079b
feat: OR-1993 rename relatie.type to relatie.relatietype
Nov 24, 2023
ba89cfc
test: OR-1993 fix detailVerenigingResponse template in tests
Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/AssociationRegistry.Admin.Api/Verenigingen/Detail/BeheerVerenigingDetailMapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ private static VerenigingDetail Map(BeheerVerenigingDetailDocument vereniging, s
private static Relatie Map(BeheerVerenigingDetailDocument.Relatie relatie, string baseUrl)
=> new()
{
Type = relatie.Type,
Relatietype = relatie.Relatietype,
AndereVereniging = Map(relatie.AndereVereniging, baseUrl),
};

Expand Down
10 changes: 4 additions & 6 deletions src/AssociationRegistry.Admin.Api/Verenigingen/Detail/ResponseModels/Relatie.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,14 @@
public class Relatie
{
/// <summary>
/// Het type relatie
/// Het type relatie
/// </summary>
[DataMember(Name = "Type")]
public string Type { get; set; } = null!;
[DataMember(Name = "Relatietype")]
public string Relatietype { get; set; } = null!;

/// <summary>
/// de gerelateerde vereniging
/// de gerelateerde vereniging
/// </summary>
[DataMember(Name = "AndereVereniging")]
public GerelateerdeVereniging AndereVereniging { get; set; } = null!;


}
4 changes: 2 additions & 2 deletions src/AssociationRegistry.Admin.Api/Verenigingen/Search/ResponseModels/Relatie.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ public class Relatie
/// <summary>
/// Het type relatie
/// </summary>
[DataMember(Name = "Type")]
public string Type { get; set; } = null!;
[DataMember(Name = "relatietype")]
public string Relatietype { get; set; } = null!;

/// <summary>
/// de gerelateerde vereniging
Expand Down
2 changes: 1 addition & 1 deletion ...sociationRegistry.Admin.ProjectionHost/Projections/Detail/BeheerVerenigingDetailMapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public static BeheerVerenigingDetailDocument.Relatie MapMoederRelatie(
AfdelingWerdGeregistreerd.MoederverenigingsData moederverenigingsData)
=> new()
{
Type = RelatieType.IsAfdelingVan.Beschrijving,
Relatietype = Relatietype.IsAfdelingVan.Beschrijving,
AndereVereniging = new BeheerVerenigingDetailDocument.Relatie.GerelateerdeVereniging
{
KboNummer = moederverenigingsData.KboNummer,
Expand Down
4 changes: 2 additions & 2 deletions ...iationRegistry.Admin.ProjectionHost/Projections/Detail/BeheerVerenigingDetailProjector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public static BeheerVerenigingDetailDocument Create(IEvent<FeitelijkeVerenigingW
HoofdactiviteitenVerenigingsloket = feitelijkeVerenigingWerdGeregistreerd.Data
.HoofdactiviteitenVerenigingsloket
.Select(BeheerVerenigingDetailMapper
.MapHoofdactiviteitVerenigingsloket)
.MapHoofdactiviteitVerenigingsloket)
.ToArray(),
Bron = feitelijkeVerenigingWerdGeregistreerd.Data.Bron,
Metadata = new Metadata(feitelijkeVerenigingWerdGeregistreerd.Sequence, feitelijkeVerenigingWerdGeregistreerd.Version),
Expand Down Expand Up @@ -271,7 +271,7 @@ public static void Apply(
document.Relaties = document.Relaties.Append(
new BeheerVerenigingDetailDocument.Relatie
{
Type = RelatieType.IsAfdelingVan.InverseBeschrijving,
Relatietype = Relatietype.IsAfdelingVan.InverseBeschrijving,
AndereVereniging = new BeheerVerenigingDetailDocument.Relatie.GerelateerdeVereniging
{
KboNummer = string.Empty,
Expand Down
2 changes: 1 addition & 1 deletion src/AssociationRegistry.Admin.Schema/Detail/BeheerVerenigingDetailDocument.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public record Sleutel

public record Relatie
{
public string Type { get; init; } = null!;
public string Relatietype { get; init; } = null!;
public GerelateerdeVereniging AndereVereniging { get; init; } = null!;

public record GerelateerdeVereniging
Expand Down
Loading
Loading