Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OR-2009 cleanup file names and image names #580

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: OR-2009 cleanup file names and image names #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ jobs:
- name: Save Api Image
if: inputs.semver != 'none'
shell: bash
run: docker image save $BUILD_DOCKER_REGISTRY/association-registry/${{ inputs.image-name }}:$SEMVER -o ~/${{ inputs.image-file}}
run: docker image save $BUILD_DOCKER_REGISTRY/${{ inputs.image-name }}:$SEMVER -o ~/${{ inputs.image-file}}
env:
BUILD_DOCKER_REGISTRY: ${{ secrets.VBR_BUILD_DOCKER_REGISTRY_TST }}
SEMVER: ${{ inputs.semver }}
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ jobs:
with:
build-target: Containerize_AcmApi
image-file: ar-acm-api-image.tar
image-name: acm-api
image-name: verenigingsregister-acmapi
test-project: AssociationRegistry.Test.Acm.Api
build-project: AssociationRegistry.Acm.Api/
semver: ${{ needs.set-release-version.outputs.version }}
Expand All @@ -176,7 +176,7 @@ jobs:
with:
build-target: Containerize_PublicApi
image-file: ar-public-api-image.tar
image-name: public-api
image-name: verenigingsregister-publicapi
test-project: AssociationRegistry.Test.Public.Api
build-project: AssociationRegistry.Public.Api/
semver: ${{ needs.set-release-version.outputs.version }}
Expand All @@ -195,7 +195,7 @@ jobs:
with:
build-target: Containerize_PublicProjections
image-file: ar-public-projections-image.tar
image-name: public-projections
image-name: verenigingsregister-publicprojections
test-project: AssociationRegistry.Test.Public.Api
build-project: AssociationRegistry.Public.ProjectionHost/
semver: ${{ needs.set-release-version.outputs.version }}
Expand All @@ -214,7 +214,7 @@ jobs:
with:
build-target: Containerize_AdminApi
image-file: ar-admin-api-image.tar
image-name: admin-api
image-name: verenigingsregister-adminapi
test-project: AssociationRegistry.Test.Admin.Api
build-project: AssociationRegistry.Admin.Api/
semver: ${{ needs.set-release-version.outputs.version }}
Expand All @@ -233,7 +233,7 @@ jobs:
with:
build-target: Containerize_AdminProjections
image-file: ar-admin-projections-image.tar
image-name: admin-projections
image-name: verenigingsregister-adminprojections
test-project: AssociationRegistry.Test.Admin.Api
build-project: AssociationRegistry.Admin.ProjectionHost/
semver: ${{ needs.set-release-version.outputs.version }}
Expand Down Expand Up @@ -426,7 +426,7 @@ jobs:
- name: Download Acm Api artifact
uses: actions/download-artifact@v3
with:
name: acm-api
name: verenigingsregister-acmapi
path: ~/

- name: Load Acm Api image
Expand All @@ -436,7 +436,7 @@ jobs:
- name: Download Public Api artifact
uses: actions/download-artifact@v3
with:
name: public-api
name: verenigingsregister-publicapi
path: ~/

- name: Load Public Api image
Expand All @@ -446,7 +446,7 @@ jobs:
- name: Download Public Projections artifact
uses: actions/download-artifact@v3
with:
name: public-projections
name: verenigingsregister-publicprojections
path: ~/

- name: Load Public Projections image
Expand All @@ -456,7 +456,7 @@ jobs:
- name: Download Admin Api artifact
uses: actions/download-artifact@v3
with:
name: admin-api
name: verenigingsregister-adminapi
path: ~/

- name: Load Admin Api image
Expand All @@ -466,7 +466,7 @@ jobs:
- name: Download Admin Projections artifact
uses: actions/download-artifact@v3
with:
name: admin-projections
name: verenigingsregister-adminprojections
path: ~/

- name: Load Admin Projections image
Expand Down
Loading