feat: or-2031 registreer inschrijving when adding kbo verenigingen #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
to be deployed after json-ld deploy |
QuintenGreenstack
force-pushed
the
or-2031-registreer
branch
from
e2f18b4 to
d0422cc
Compare
| var duplicateResult = await CheckForDuplicate(command.KboNummer); | ||
|
|
||
| if (duplicateResult.IsFailure()) return duplicateResult; | ||
|
|
||
| var vereniging = await _magdaGeefVerenigingService.GeefVereniging(command.KboNummer, message.Metadata, cancellationToken); | ||
| var registreerInschrijvingResult = await RegistreerInschrijving(command.KboNummer, message.Metadata, cancellationToken); |
There was a problem hiding this comment.
Why trycatch -> return Result -> throw new?
There was a problem hiding this comment.
todo: let private method RegistreerInschrijving throw.
|
|
||
| return await RegistreerVereniging(vereniging, message.Metadata, cancellationToken); | ||
| if (geefVerenigingResult.IsFailure()) throw new GeenGeldigeVerenigingInKbo(); |
There was a problem hiding this comment.
What if server stops on this line?
koenmetsu
commented
Mar 4, 2024
|
|
||
| var response = _mapper.Map(gebeurtenissen); | ||
|
|
||
| return Ok(response); |
|
|
🎉 This PR is included in version 8.79.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.