Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Bump upload-artifact actions version to v4 #436

Merged
merged 1 commit into from
Jan 7, 2025
Merged

ENH: Bump upload-artifact actions version to v4 #436

merged 1 commit into from
Jan 7, 2025
+1 −1

Conversation

jhlegarreta
Copy link
Member

Bump upload-artifact actions version to v4.

Fixes:

Artifact actions v3 will be closing down by January 30, 2025.
You are receiving this email because you have GitHub Actions
workflows using v3 of actions/upload-artifact or
actions/download-artifact. After this date using v3 of these
actions will result in a workflow failure.

received via email on Jan 7, 2025 from GitHub.

@jhlegarreta
ENH: Bump upload-artifact actions version to v4
f0bd2af 
Bump `upload-artifact` actions version to v4.

Fixes:
```
Artifact actions v3 will be closing down by January 30, 2025.
You are receiving this email because you have GitHub Actions
workflows using v3 of actions/upload-artifact or
actions/download-artifact. After this date using v3 of these
actions will result in a workflow failure.
```

received via email on Jan 7, 2025 from GitHub.
@github-actions github-actions bot added type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels Jan 7, 2025
@dzenanz dzenanz requested a review from thewtex January 7, 2025 17:29
@jhlegarreta
Copy link
Member Author

jhlegarreta commented Jan 7, 2025 •
edited
Loading

Linting failure being addressed in InsightSoftwareConsortium/ITKClangFormatLinterAction#5

Some ITK build failures are related to the issues with the tiff library:

itktiff-5.4.lib(tif_luv.c.obj) : error LNK2005: __ucrt_int_to_float already defined in itktiff-5.4.lib(tif_aux.c.obj)

itktiff-5.4.lib(tif_color.c.obj) : error LNK2005: __ucrt_int_to_float already defined in itktiff-5.4.lib(tif_aux.c.obj)

bin\itkTestDriver.exe : fatal error LNK1169: one or more multiply defined symbols found

https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/actions/runs/12656100970/job/35267919219?pr=436#step:9:3254

I assume the ITK version needs to be bumped.

thewtex
thewtex approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jhlegarreta !

@thewtex thewtex merged commit 2655a81 into InsightSoftwareConsortium:master Jan 7, 2025
3 of 13 checks passed
@jhlegarreta jhlegarreta deleted the BumpUploadArtifactAction branch January 8, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewtex thewtex thewtex approved these changes

Assignees
No one assigned
Labels
type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhlegarreta @thewtex