Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement python array API Inspection namespace #2275

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 23, 2025

The PR proposes to implement dpnp.__array_namespace_info__, what is a python array API Inspection namespace.
It is required to achieve the compliance with python array API.
The implementation leverages on appropriate namespace exposed by dpctl.tensor.

In addition, this PR makes an __array_api_version__ attribute available in dpnp. It also borrowed from dpctl.

The PR adds a dedication documentation page describing Array API standard compatibility, including reference on new dpnp.__array_namespace_info__.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jan 23, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 23, 2025

Coverage Status

coverage: 71.28% (+0.005%) from 71.275%
when pulling 6b5ca27 on impl-array_namespace_info
into 0181564 on master.

@antonwolfy antonwolfy marked this pull request as ready for review January 23, 2025 18:54
@antonwolfy
Copy link
Contributor Author

Link to rendered documentation: https://intelpython.github.io/dpnp/pull/2275/reference/array_api.html

Copy link
Contributor

Array API standard conformance tests for dpnp=0.17.0dev5=py312he4f9c94_10 ran successfully.
Passed: 966
Failed: 1
Skipped: 33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants