-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new tests to improve coverage stats #2277
base: master
Are you sure you want to change the base?
Conversation
Array API standard conformance tests for dpnp=0.17.0dev5=py312he4f9c94_4 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @vlad-perevezentsev
expected = dpnp.matmul(a, b) | ||
assert_allclose(result, expected) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both output arrays are dpnp.ndarray, so we no need to use assert util function from numpy here:
expected = dpnp.matmul(a, b) | |
assert_allclose(result, expected) | |
expected = a @ b | |
assert (result == expected).all() |
This PR continues #2268 and #2272 and suggests adding a couple new tests to slightly improve code coverage stats