Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new tests to improve coverage stats #2277

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR continues #2268 and #2272 and suggests adding a couple new tests to slightly improve code coverage stats

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

dpnp/tests/test_mathematical.py Outdated Show resolved Hide resolved
dpnp/tests/test_mathematical.py Outdated Show resolved Hide resolved
dpnp/tests/test_utils.py Outdated Show resolved Hide resolved
dpnp/tests/test_utils.py Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Jan 24, 2025

Coverage Status

coverage: 71.289% (+0.01%) from 71.275%
when pulling f45cf8f on new_tests_coverage
into 0181564 on master.

Copy link
Contributor

Array API standard conformance tests for dpnp=0.17.0dev5=py312he4f9c94_4 ran successfully.
Passed: 957
Failed: 0
Skipped: 43

Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @vlad-perevezentsev

Comment on lines +479 to +480
expected = dpnp.matmul(a, b)
assert_allclose(result, expected)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both output arrays are dpnp.ndarray, so we no need to use assert util function from numpy here:

Suggested change
expected = dpnp.matmul(a, b)
assert_allclose(result, expected)
expected = a @ b
assert (result == expected).all()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants