Skip to content

Commit

Permalink
Startup steps reduced down to changing one bool value (#601)
Browse files Browse the repository at this point in the history
## Description

Newcomers to this repo are not able to immediately start up the
application due to the private nuget feed. Final solution requires newcomers to change on boolean value in Directory.Build.props to tell lower level config files not to reference ContentFeedNuget, which is inaccessible to those without
permissions.

---------

Co-authored-by: Benjamin Michaelis <git@relay.benjamin.michaelis.net>
  • Loading branch information
Joshua-Lester3 and BenjaminMichaelis authored Oct 15, 2024
1 parent 8a47bea commit d93cfbe
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 6 deletions.
1 change: 1 addition & 0 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<PreserveCompilationContext>true</PreserveCompilationContext>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>
<AccessToNugetFeed>true</AccessToNugetFeed>

<!-- https://aka.ms/vs-build-acceleration -->
<AccelerateBuildsInVisualStudio>True</AccelerateBuildsInVisualStudio>
Expand Down
7 changes: 3 additions & 4 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,14 @@
<PropertyGroup>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
<CentralPackageTransitivePinningEnabled>false</CentralPackageTransitivePinningEnabled>
<AccessToNugetFeed>true</AccessToNugetFeed>
<ToolingPackagesVersion>1.1.1.4359</ToolingPackagesVersion>
<ToolingPackagesVersion>1.1.1.4330</ToolingPackagesVersion>
</PropertyGroup>
<ItemGroup Condition="$(AccessToNugetFeed)">
<PackageVersion Include="ContentFeedNuget" Version="$(ToolingPackagesVersion)" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.Sqlite" Version="8.0.10" />
</ItemGroup>
<ItemGroup>
<PackageVersion Include="EssentialCSharp.Shared.Models" Version="1.1.1.4359" />
<PackageVersion Include="EssentialCSharp.Shared.Models" Version="1.1.1.4330" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.Sqlite" Version="8.0.8" />
<PackageVersion Include="AspNet.Security.OAuth.GitHub" Version="8.2.0" />
<PackageVersion Include="coverlet.collector" Version="6.0.2" />
<PackageVersion Include="HtmlAgilityPack" Version="1.11.67" />
Expand Down
5 changes: 3 additions & 2 deletions EssentialCSharp.Web/EssentialCSharp.Web.csproj
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
<Project Sdk="Microsoft.NET.Sdk.Web">
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<AccessToNugetFeed>true</AccessToNugetFeed>
</PropertyGroup>
<ItemGroup>
<PlaceholderHtmlFile Include="$(ProjectDir)Placeholders/*.html" />
<PlaceholderJsonFile Include="$(ProjectDir)Placeholders/*.json" />
</ItemGroup>
<ItemGroup Condition="$(AccessToNugetFeed)">
<PackageReference Include="ContentFeedNuget" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="ContentFeedNuget" />
<PackageReference Include="AspNet.Security.OAuth.GitHub" />
<PackageReference Include="EssentialCSharp.Shared.Models" />
<PackageReference Include="HtmlAgilityPack" />
Expand Down
3 changes: 3 additions & 0 deletions nuget.config
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
<add key="nuget" value="https://api.nuget.org/v3/index.json" />
<add key="EssentialCSharp" value="https://pkgs.dev.azure.com/intelliTect/_packaging/EssentialCSharp/nuget/v3/index.json" />
</packageSources>
<disabledPackageSources>
<add key="EssentialCSharp" value="!$(AccessToNugetFeed)" />
</disabledPackageSources>
<packageSourceMapping>
<packageSource key="nuget">
<package pattern="*" />
Expand Down

0 comments on commit d93cfbe

Please sign in to comment.