Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Different startup steps implementation since other fix fails to restore #622

Merged
merged 16 commits into from
Nov 1, 2024

Conversation

Joshua-Lester3
Copy link
Collaborator

Description

Pull Request #601 implementation fails to restore. I believe I narrowed the problem down to the added disabledPackageSources property in nuget.config, though my access to the Nuget feed isn't currently working.

This solution takes the disabling effect out of nuget.config and puts it in the Directory.Packages.props. In the .props file it conditionally restores the private Nuget feed based on the single bool prop, AccessToNugetFeed, defined in Directory.Build.props.

Credit: GitHub issue 1, GitHub issue 2

@Joshua-Lester3
Copy link
Collaborator Author

Restores on my machine - not quite sure why the runner isn't able to.

Copy link
Member

@Keboo Keboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@BenjaminMichaelis BenjaminMichaelis merged commit f5f0498 into IntelliTect:main Nov 1, 2024
6 checks passed
Joshua-Lester3 added a commit to Joshua-Lester3/EssentialCSharp.Web that referenced this pull request Dec 4, 2024
…restore (IntelliTect#622)

## Description

Pull Request IntelliTect#601 implementation fails to restore. I believe I narrowed
the problem down to the added `disabledPackageSources` property in
nuget.config, though my access to the Nuget feed isn't currently
working.

This solution takes the disabling effect out of nuget.config and puts it
in the Directory.Packages.props. In the .props file it conditionally
restores the private Nuget feed based on the single bool prop,
`AccessToNugetFeed`, defined in Directory.Build.props.

Credit: [GitHub issue 1](NuGet/Home#6045),
[GitHub issue 2](NuGet/Home#3972)

---------

Co-authored-by: Benjamin Michaelis <git@relay.benjamin.michaelis.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants