Adjust web side for new tooling changes (Key -> Keys and OrderOnPage) #674

Joshua-Lester3 · 2024-12-04T00:05:09Z

Description

Adding support for new Tooling side update: adjusting from SiteMapping.Key to Keys as well as sorting by OrderOnPage since the new Tooling update changes how sitemap.json is ordered.

Ensure that your pull request has followed all the steps below:

Code compilation
Created tests which fail without the change (if possible)
All tests passing

This reverts commit 710418c.

EssentialCSharp.Web/Views/Shared/_Layout.cshtml

EssentialCSharp.Web/Services/SiteMappingDto.cs

…into BMichaelis/UpdateSitemaps

This reverts commit 1fb2ffb. Revert "Change stringify implementation" This reverts commit 98f4423. Redo buried changes for key => keys

This reverts commit bb23388.

Joshua-Lester3 had a problem deploying to BuildAndUploadImage December 4, 2024 00:05 — with GitHub Actions Failure

Joshua-Lester3 had a problem deploying to BuildAndUploadImage December 4, 2024 00:28 — with GitHub Actions Failure

Joshua-Lester3 had a problem deploying to BuildAndUploadImage December 4, 2024 00:30 — with GitHub Actions Failure

Joshua-Lester3 had a problem deploying to BuildAndUploadImage December 4, 2024 00:41 — with GitHub Actions Failure

Joshua-Lester3 temporarily deployed to BuildAndUploadImage December 4, 2024 00:41 — with GitHub Actions Inactive

Joshua-Lester3 force-pushed the BMichaelis/UpdateSitemaps branch from 7b2c3ec to eefdf2d Compare December 4, 2024 00:51

Joshua-Lester3 had a problem deploying to BuildAndUploadImage December 4, 2024 00:51 — with GitHub Actions Failure

Joshua-Lester3 temporarily deployed to BuildAndUploadImage December 4, 2024 00:51 — with GitHub Actions Inactive

BenjaminMichaelis force-pushed the main branch from 70452a1 to 23ff1d6 Compare December 4, 2024 00:55

BenjaminMichaelis and others added 8 commits December 3, 2024 16:57

WIP

ff8ede4

Working solution (only if EssentialCSharp.Common adds orderOnPage)

9a41866

Makes this solution testable (bypassing EssentialCSharp.Common)

5dacaea

Revert "Makes this solution testable (bypassing EssentialCSharp.Common)"

0fd9b98

This reverts commit 710418c.

Update version and adjust tests

c83c4db

Remove comment

03fdc4e

Fix javascript side

09500a3

Add changes for Layout

3a9a1ca

Joshua-Lester3 force-pushed the BMichaelis/UpdateSitemaps branch from eefdf2d to 3a9a1ca Compare December 4, 2024 00:58

Joshua-Lester3 temporarily deployed to BuildAndUploadImage December 4, 2024 00:58 — with GitHub Actions Inactive

Change naming for dto

9cf3dcd

Joshua-Lester3 temporarily deployed to BuildAndUploadImage December 4, 2024 16:31 — with GitHub Actions Inactive

BenjaminMichaelis requested a review from ascott18 December 5, 2024 00:41

ascott18 reviewed Dec 5, 2024

View reviewed changes

EssentialCSharp.Web/Views/Shared/_Layout.cshtml Outdated Show resolved Hide resolved

BenjaminMichaelis reviewed Dec 5, 2024

View reviewed changes

EssentialCSharp.Web/Services/SiteMappingDto.cs Show resolved Hide resolved

Update SiteMappingDto.cs

f001154

Joshua-Lester3 temporarily deployed to BuildAndUploadImage December 5, 2024 20:41 — with GitHub Actions Inactive

Joshua-Lester3 added 3 commits December 5, 2024 12:47

Change stringify implementation

98f4423

Add helper method + more key => keys fixes

1fb2ffb

Merge remote-tracking branch 'IntelliTect/BMichaelis/UpdateSitemaps' …

d55c821

…into BMichaelis/UpdateSitemaps

Joshua-Lester3 temporarily deployed to BuildAndUploadImage December 5, 2024 21:55 — with GitHub Actions Inactive

Joshua-Lester3 added 2 commits December 5, 2024 15:33

Revert "Add helper method + more key => keys fixes"

cafc5aa

This reverts commit 1fb2ffb. Revert "Change stringify implementation" This reverts commit 98f4423. Redo buried changes for key => keys

Redo design and refactor

52e183a

Joshua-Lester3 temporarily deployed to BuildAndUploadImage December 5, 2024 23:37 — with GitHub Actions Inactive

Update site.js

bb23388

Joshua-Lester3 temporarily deployed to BuildAndUploadImage December 13, 2024 19:21 — with GitHub Actions Inactive

Joshua-Lester3 added 2 commits December 13, 2024 11:22

Revert "Update site.js"

0bb97cd

This reverts commit bb23388.

Fix unnecessary change

20a165a

Joshua-Lester3 temporarily deployed to BuildAndUploadImage December 13, 2024 19:25 — with GitHub Actions Inactive

Adjust whitespace

8ef36eb

Joshua-Lester3 temporarily deployed to BuildAndUploadImage December 13, 2024 19:26 — with GitHub Actions Inactive

Last whitespace adjusting

ce1765c

Joshua-Lester3 temporarily deployed to BuildAndUploadImage December 13, 2024 19:26 — with GitHub Actions Inactive

BenjaminMichaelis approved these changes Dec 14, 2024

View reviewed changes

Joshua-Lester3 merged commit 67a6148 into main Dec 14, 2024
7 checks passed

Joshua-Lester3 deleted the BMichaelis/UpdateSitemaps branch December 14, 2024 20:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adjust web side for new tooling changes (Key -> Keys and OrderOnPage) #674

Adjust web side for new tooling changes (Key -> Keys and OrderOnPage) #674

Joshua-Lester3 commented Dec 4, 2024 •

edited

Loading

Adjust web side for new tooling changes (Key -> Keys and OrderOnPage) #674

Adjust web side for new tooling changes (Key -> Keys and OrderOnPage) #674

Conversation

Joshua-Lester3 commented Dec 4, 2024 • edited Loading

Description

Ensure that your pull request has followed all the steps below:

Joshua-Lester3 commented Dec 4, 2024 •

edited

Loading