Skip to content

Commit

Permalink
Fix unappropriated log of unknown storage class
Browse files Browse the repository at this point in the history
A warn log may appear when rebuilding the history file from a tradspool
directory whereas there is nothing to worry about (as SMerrorstr is not
set for the corresponding article wrongly reported in error).

Thanks to Jesse Rehmer for the bug report.
  • Loading branch information
Julien-Elie committed Nov 2, 2023
1 parent e27588c commit 6e07649
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion storage/tradspool/tradspool.c
Original file line number Diff line number Diff line change
Expand Up @@ -1277,7 +1277,7 @@ tradspool_next(ARTHANDLE *article, const RETRTYPE amount)
/* Only log an error if art->len is non-zero, since otherwise we get
all the ones skipped via the hard-link skipping algorithm
commented above. */
if (art->len > 0)
if (art->len > 0 && sub == NULL)
warn("tradspool: can't determine class of %s: %s",
TokenToText(token), SMerrorstr);
} else {
Expand Down

0 comments on commit 6e07649

Please sign in to comment.