scanspool: Detect directories with all-digit name

Recognize timehash and timecaf directories, but still do not parse articles.

see #192

doc/pod/news.pod

@@ -34,9 +34,11 @@ as a format like C<Jul 29 04:15:01> was expected.
 
 =item *
 
-B<scanspool> now detects empty files in a tradspool news spool, correctly
-parses continuation lines in header fields, and can automatically remove
-articles reported to have a problem (when run with the new B<-r> flag).
+B<scanspool> now detects empty files in a tradspool news spool, directories
+with an all-digit component (which may conflict with a possible file with
+the same name), correctly parses continuation lines in header fields, and can
+automatically remove articles reported to have a problem (when run with the
+new B<-r> flag).
 
 =item *
 

doc/pod/scanspool.pod

@@ -13,6 +13,9 @@ It will scan the F<active> file as well as all articles in the spool and
 report on the errors it encounters.  As this may take a while, using the
 B<-v> switch is recommended to see how far the program has progressed.
 
+B<scanspool> will skip any file named other than just all-digits when treating
+the contents of the news spool.
+
 First, B<scanspool> scans the F<active> file, noting problems such as:
 
 =over 4
@@ -63,6 +66,9 @@ are in a newsgroup to which they do not belong.
 
 =back
 
+B<scanspool> will also complain about directories with an all-digit component
+as they may conflict with a possible file with the same name.
+
 B<scanspool> understands aliased newsgroups.  Thus, if an article is posted
 to foo.old.name that is aliased to foo.bar, it will be expected to
 be found under foo.bar and not foo.old.name.
@@ -159,13 +165,6 @@ Verbose messages start with a tab.
 
 =back
 
-=head1 BUGS
-
-B<scanspool> is unable to detect and properly deal with spool formats
-other than tradspool.  However, if the files that store your articles
-are named other than just all-digits, they will simply be skipped
-(and your F<active> is still checked).
-
 =head1 HISTORY
 
 B<scanspool> was written by Landon Curt Noll (chongo was here /\../\).

frontends/scanspool.in

@@ -28,6 +28,9 @@ use strict;
 #     - are in a directory for which there is no newsgroup in the active file
 #     - are in a newsgroup to which they do not belong
 #
+# scanspool will also complain about directories with an all-digit component
+# as they may conflict with a possible file with the same name.
+#
 # scanspool understands aliased groups.  Thus, if an article is posted
 # to foo.old.name that is aliased to foo.bar, it will be expected to
 # be found under foo.bar and not foo.old.name.
@@ -342,7 +345,8 @@ sub check_spool {
     #
     if (
         !open $FINDFILE, '-|',
-        "find . \\( -type f -o -type l \\) -name '[0-9]*' -print 2>&1"
+        "find . \\( -type d -o -type f -o -type l \\) -name '[0-9]*' "
+        . "-print 2>&1"
     ) {
         fatal(3, "cannot start find in $spool");
     }
@@ -369,6 +373,21 @@ sub check_spool {
         # skip if not a numeric basename
         next if ($filename !~ m:/\d+$:o);
 
+        # skip timehash and timecaf spools
+        next
+          if $filename =~ /^time-\d\d\/\d\d/
+          or $filename =~ /^time-\d\d\/..\/\d\d/
+          or $filename =~ /^timecaf-\d\d\/\d\d/;
+
+        if (-d "$filename") {
+            problem(
+                "WARNING:",
+                "$filename: directory with an all-digit component",
+                "(may conflict with a possible file with the same name)"
+            );
+            next;
+        }
+
         # get the article's newsgroup name (based on its path from $spool)
         $artgrp = $filename;
         $artgrp =~ s#/\d+$##o;